linux-kernel - Re: [PATCH v32 2/6] fs/proc/task_mmu: Implement IOCTL to get and optionally clear info about PTEs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202308181520.yCq9Z26w-lkp@intel.com>
Date:   Fri, 18 Aug 2023 15:16:04 +0800
From:   kernel test robot <lkp@...el.com>
To:     Muhammad Usama Anjum <usama.anjum@...labora.com>,
        Peter Xu <peterx@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Michał Mirosław <emmir@...gle.com>,
        Andrei Vagin <avagin@...il.com>,
        Danylo Mocherniuk <mdanylo@...gle.com>,
        Paul Gofman <pgofman@...eweavers.com>
Cc:     oe-kbuild-all@...ts.linux.dev,
        Linux Memory Management List <linux-mm@...ck.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Christian Brauner <brauner@...nel.org>,
        Yang Shi <shy828301@...il.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        "Liam R . Howlett" <Liam.Howlett@...cle.com>,
        Yun Zhou <yun.zhou@...driver.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Alex Sierra <alex.sierra@....com>,
        Muhammad Usama Anjum <usama.anjum@...labora.com>,
        Matthew Wilcox <willy@...radead.org>,
        Pasha Tatashin <pasha.tatashin@...een.com>,
        Axel Rasmussen <axelrasmussen@...gle.com>,
        "Gustavo A . R . Silva" <gustavoars@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kselftest@...r.kernel.org, Greg KH <greg@...ah.com>,
        kernel@...labora.com, Cyrill Gorcunov <gorcunov@...il.com>,
        Mike Rapoport <rppt@...nel.org>, Nadav Amit <namit@...are.com>
Subject: Re: [PATCH v32 2/6] fs/proc/task_mmu: Implement IOCTL to get and
 optionally clear info about PTEs

Hi Muhammad,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on next-20230817]
[cannot apply to linus/master v6.5-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Muhammad-Usama-Anjum/userfaultfd-UFFD_FEATURE_WP_ASYNC/20230816-193454
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20230816113049.1697849-3-usama.anjum%40collabora.com
patch subject: [PATCH v32 2/6] fs/proc/task_mmu: Implement IOCTL to get and optionally clear info about PTEs
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20230818/202308181520.yCq9Z26w-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230818/202308181520.yCq9Z26w-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308181520.yCq9Z26w-lkp@intel.com/

All errors (new ones prefixed by >>):

   fs/proc/task_mmu.c: In function 'pagemap_scan_thp_entry':
>> fs/proc/task_mmu.c:2077:28: error: 'HPAGE_SIZE' undeclared (first use in this function); did you mean 'PAGE_SIZE'?
    2077 |         if (end != start + HPAGE_SIZE) {
         |                            ^~~~~~~~~~
         |                            PAGE_SIZE
   fs/proc/task_mmu.c:2077:28: note: each undeclared identifier is reported only once for each function it appears in


vim +2077 fs/proc/task_mmu.c

  2044	
  2045	static int pagemap_scan_thp_entry(pmd_t *pmd, unsigned long start,
  2046					  unsigned long end, struct mm_walk *walk)
  2047	{
  2048	#ifdef CONFIG_TRANSPARENT_HUGEPAGE
  2049		struct pagemap_scan_private *p = walk->private;
  2050		struct vm_area_struct *vma = walk->vma;
  2051		unsigned long categories;
  2052		spinlock_t *ptl;
  2053		int ret = 0;
  2054	
  2055		ptl = pmd_trans_huge_lock(pmd, vma);
  2056		if (!ptl)
  2057			return -ENOENT;
  2058	
  2059		categories = p->cur_vma_category | pagemap_thp_category(*pmd);
  2060	
  2061		if (!pagemap_scan_is_interesting_page(categories, p))
  2062			goto out_unlock;
  2063	
  2064		ret = pagemap_scan_output(categories, p, start, &end);
  2065		if (start == end)
  2066			goto out_unlock;
  2067	
  2068		if (~p->arg.flags & PM_SCAN_WP_MATCHING)
  2069			goto out_unlock;
  2070		if (~categories & PAGE_IS_WRITTEN)
  2071			goto out_unlock;
  2072	
  2073		/*
  2074		 * Break huge page into small pages if the WP operation
  2075		 * needs to be performed on a portion of the huge page.
  2076		 */
> 2077		if (end != start + HPAGE_SIZE) {
  2078			spin_unlock(ptl);
  2079			split_huge_pmd(vma, pmd, start);
  2080			pagemap_scan_backout_range(p, start, end);
  2081			/* Report as if there was no THP */
  2082			return -ENOENT;
  2083		}
  2084	
  2085		make_uffd_wp_pmd(vma, start, pmd);
  2086		flush_tlb_range(vma, start, end);
  2087	out_unlock:
  2088		spin_unlock(ptl);
  2089		return ret;
  2090	#else /* !CONFIG_TRANSPARENT_HUGEPAGE */
  2091		return -ENOENT;
  2092	#endif
  2093	}
  2094	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki