Message-ID: <20230818075057.3426088-1-brpol@chromium.org>
Date:   Fri, 18 Aug 2023 07:43:05 +0000
From:   Brandon Pollack <brpol@...omium.org>
To:     marius.vlad@...labora.com, jshargo@...omium.org
Cc:     corbet@....net, dri-devel@...ts.freedesktop.org,
        hamohammed.sa@...il.com, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, mairacanal@...eup.net,
        melissa.srw@...il.com, mripard@...nel.org,
        rodrigosiqueiramelo@...il.com, tzimmermann@...e.de,
        airlied@...il.com, daniel@...ll.ch,
        maarten.lankhorst@...ux.intel.com, mduggan@...omium.org,
        hirono@...omium.org, Brandon Pollack <brpol@...omium.org>
Subject: [PATCH v3 0/7] Adds support for ConfigFS to VKMS!

Since Jim is busy with other work and I'm working on some things that
rely on this, I've taken up the task of doing the iterations.  I've
addressed the comments as best I can (those replies are to each
individual change) and here is the patch set to go with those.

I added my own signoff to each commit, but I've left jshargo@ as the
author of all the commits he wrote.  I'm sure there is still more to
address and the ICT tests that were writtein parallel to this may also
need some additions, but I'm hoping we're in a good enough state to get
this in and iterate from there soon.

Since V3:
========
I've added hotplug support in the latest patch.  This has been reviewed some
and the notes from that review are addressed here as well.

Relevant/Utilizing work:
=======================
I've built a while test framework based on this as proof it functions (though
I'm sure there may be lingering bugs!).  You can check that out on
crrev.com if you are interested and need to get started yourself (but be
aware of any licensing that may differ from the kernel itself!  Make
sure you understand the license:

https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/platform/tast-tests/LICENSE

That said, you can see the changes in review on the crrev gerrit:

https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/4666669

Outro:
=====
I really appreciate everyone's input and tolerance in getting these
changes in.  Jim's first patch series was this, and other than some
small cleanups and documentation, taking over it is also mine.

Thank you everyone :)

Original Message:
>Usage
>=====
>
>After installing these patches, you can create a VKMS device with two
>displays and a movable overlay like so (this is documented in the
>patches):
>
>  $ modprobe vkms enable_overlay=1 enable_cursor=1 enable_writeback=1
>  $ mkdir -p /config/
>  $ mount -t configfs none /config
>
>  $ export DRM_PLANE_TYPE_PRIMARY=1
>  $ export DRM_PLANE_TYPE_CURSOR=2
>  $ export DRM_PLANE_TYPE_OVERLAY=0
>
>  $ mkdir /config/vkms/test
>
>  $ mkdir /config/vkms/test/planes/primary
>  $ echo $DRM_PLANE_TYPE_PRIMARY > /config/vkms/test/planes/primary/type
>
>  $ mkdir /config/vkms/test/planes/other_primary
>  $ echo $DRM_PLANE_TYPE_PRIMARY > /config/vkms/test/planes/other_primary/type
>
>  $ mkdir /config/vkms/test/planes/cursor
>  $ echo $DRM_PLANE_TYPE_CURSOR > /config/vkms/test/planes/cursor/type
>
>  $ mkdir /config/vkms/test/planes/overlay
>  $ echo $DRM_PLANE_TYPE_OVERLAY > /config/vkms/test/planes/overlay/type
>
>  $ mkdir /config/vkms/test/crtcs/crtc
>  $ mkdir /config/vkms/test/crtcs/crtc_other
>  $ mkdir /config/vkms/test/encoders/encoder
>  $ mkdir /config/vkms/test/connectors/connector
>
>  $ ln -s /config/vkms/test/encoders/encoder /config/vkms/test/connectors/connector/possible_encoders
>  $ ln -s /config/vkms/test/crtcs/crtc /config/vkms/test/encoders/encoder/possible_crtcs/
>  $ ln -s /config/vkms/test/crtcs/crtc /config/vkms/test/planes/primary/possible_crtcs/
>  $ ln -s /config/vkms/test/crtcs/crtc /config/vkms/test/planes/cursor/possible_crtcs/
>  $ ln -s /config/vkms/test/crtcs/crtc /config/vkms/test/planes/overlay/possible_crtcs/
>  $ ln -s /config/vkms/test/crtcs/crtc_other /config/vkms/test/planes/overlay/possible_crtcs/
>  $ ln -s /config/vkms/test/crtcs/crtc_other /config/vkms/test/planes/other_primary/possible_crtcs/
>
>  $ echo 1 > /config/vkms/test/enabled
>
>Changes within core VKMS
>========================
>
>This introduces a few important changes to the overall structure of
>VKMS:
>
>  - Devices are now memory managed!
>  - Support for multiple CRTCs and other objects has been added
>
>Since v1
>========
>
>  - Added DRMM memory management to automatically clean up resources
>  - Added a param to disable the default device
>  - Renamed "cards" to "devices" to improve legibility
>  - Added a lock for the configfs setup handler
>  - Moved all the new docs into the relevant .c file
>  - Addressed as many of sean@...rly.run as possible
>
>Testing
>=======
>
>  - New IGT tests (see
>    gitlab.freedesktop.org/jshargo/igt-gpu-tools/-/merge_requests/1)
>  - Existing IGT tests (excluding .*suspend.*, including .*kms_flip.*
>    .*kms_writeback.* .*kms_cursor_crc.*, .*kms_plane.*)
>
>Outro
>=====
>
>I'm excited to share these changes, it's my still my first kernel patch
>and I've been putting a lot of love into these.

Brandon Pollack (1):
  drm/vkms Add hotplug support via configfs to VKMS.

Jim Shargo (6):
  drm/vkms: Back VKMS with DRM memory management instead of static
    objects
  drm/vkms: Support multiple DRM objects (crtcs, etc.) per VKMS device
  drm/vkms: Provide platform data when creating VKMS devices
  drm/vkms: Add ConfigFS scaffolding to VKMS
  drm/vkms: Support enabling ConfigFS devices
  drm/vkms: Add a module param to enable/disable the default device

 Documentation/gpu/vkms.rst            |  20 +-
 drivers/gpu/drm/Kconfig               |   1 +
 drivers/gpu/drm/vkms/Makefile         |   1 +
 drivers/gpu/drm/vkms/vkms_composer.c  |  30 +-
 drivers/gpu/drm/vkms/vkms_configfs.c  | 724 ++++++++++++++++++++++++++
 drivers/gpu/drm/vkms/vkms_crtc.c      | 103 ++--
 drivers/gpu/drm/vkms/vkms_drv.c       | 206 +++++---
 drivers/gpu/drm/vkms/vkms_drv.h       | 182 +++++--
 drivers/gpu/drm/vkms/vkms_output.c    | 340 ++++++++++--
 drivers/gpu/drm/vkms/vkms_plane.c     |  38 +-
 drivers/gpu/drm/vkms/vkms_writeback.c |  33 +-
 11 files changed, 1443 insertions(+), 235 deletions(-)
 create mode 100644 drivers/gpu/drm/vkms/vkms_configfs.c

-- 
2.42.0.rc1.204.g551eb34607-goog

Powered by blists - more mailing lists