linux-kernel - Re: [PATCH 1/2] dt-bindings: mfd: st,stpmic1: Add missing unevaluatedProperties for each regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa75415c-89fa-451b-2418-9f2fd6fab93f@linaro.org>
Date:   Fri, 18 Aug 2023 11:00:26 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Lee Jones <lee@...nel.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        pascal Paillet <p.paillet@...s.st.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mfd: st,stpmic1: Add missing
 unevaluatedProperties for each regulator

On 17/08/2023 13:52, Lee Jones wrote:
> On Tue, 25 Jul 2023, Krzysztof Kozlowski wrote:
> 
>> On 25/07/2023 14:37, Krzysztof Kozlowski wrote:
>>> Each regulator node, which references common regulator.yaml schema,
>>> should disallow additional or unevaluated properties.  Otherwise
>>> mistakes in properties will go unnoticed.  unevaluatedProperties:false
>>> requires listing existing properties (present in example and in other
>>> regulators of this device).
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>> ---
>>>  Documentation/devicetree/bindings/mfd/st,stpmic1.yaml | 10 ++++++++++
>>>  1 file changed, 10 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
>>> index 97c61097f9e2..1a1ced489ef7 100644
>>> --- a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
>>> +++ b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
>>> @@ -189,6 +189,16 @@ properties:
>>>  
>>>        "^(buck[1-4]|ldo[1-6]|boost|vref_ddr|pwr_sw[1-2])$":
>>>          $ref: ../regulator/regulator.yaml
>>> +        unevaluatedProperties: false
>>> +
>>> +        properties:
>>> +          interrupts:
>>> +            maxItems: 1
>>> +
>>> +          st,mask-reset:
>>> +            description: mask reset for this regulator, the regulator configuration
>>> +              is maintained during pmic reset.
>>> +            $ref: /schemas/types.yaml#/definitions/flag
>>
>> After further testing I see this patch is wrong. There are already
>> buck[1-4] entries, so this is duplicating things. I will send v2.
> 
> Are you still planning on resending this set?
> 

I already did and you took it. Email subject was different, though:

https://lore.kernel.org/all/20230726065633.74924-1-krzysztof.kozlowski@linaro.org/
Best regards,
Krzysztof