linux-kernel - Re: [PATCH v4] PCI/VGA: Make the vga_is_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ffb3525-487e-20b3-4024-66470f1407f1@loongson.cn>
Date:   Fri, 18 Aug 2023 17:31:34 +0800
From:   suijingfeng <suijingfeng@...ngson.cn>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        loongson-kernel@...ts.loongnix.cn, linux-pci@...r.kernel.org,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v4] PCI/VGA: Make the vga_is_firmware_default() less
 arch-dependent

Hi,


On 2023/8/18 06:08, Bjorn Helgaas wrote:
>> This patch makes the vga_is_firmware_default() function works on whatever
>> arch that has UEFI GOP support. But we make it available only on platforms
>> where PCI resource relocation happens. if the provided method proves to be
>> effective and reliable, it can be expanded to other arch easily.
>>
>> v2:
>> 	* Fix test robot warnnings and fix typos
>>
>> v3:
>> 	* Fix linkage problems if the global screen_info is not exported
>>
>> v4:
>> 	* Handle linkage problems by hiding behind of CONFIG_SYSFB,
>> 	* Drop side-effects and simplify.
> The v2, v3, v4 changelog is nice, but we don't need it in the commit
> log itself, where it will become part of the git history.  It should
> go in a cover letter or after the "---" marker:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v6.0#n678

Thanks for point it out, now I know. Will be fixed at the next version.