linux-kernel - Re: "Use slab_build_skb() instead" deprecation warning triggered by tg3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49c2e556-fd75-751e-3b0c-c51c3245f94c@proxmox.com>
Date:   Fri, 18 Aug 2023 13:22:10 +0200
From:   Fiona Ebner <f.ebner@...xmox.com>
To:     Bagas Sanjaya <bagasdotme@...il.com>, linux-kernel@...r.kernel.org
Cc:     siva.kallam@...adcom.com, prashant@...adcom.com,
        mchan@...adcom.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, richardcochran@...il.com,
        jdelvare@...e.com, Guenter Roeck <linux@...ck-us.net>,
        netdev@...r.kernel.org, linux-hwmon@...r.kernel.org,
        keescook@...omium.org,
        Linux Regressions <regressions@...ts.linux.dev>
Subject: Re: "Use slab_build_skb() instead" deprecation warning triggered by
 tg3

Am 18.08.23 um 13:12 schrieb Bagas Sanjaya:
> On Fri, Aug 18, 2023 at 10:05:11AM +0200, Fiona Ebner wrote:
>> Hi,
>> we've got a user report about the WARN_ONCE introduced by ce098da1497c
>> ("skbuff: Introduce slab_build_skb()") [0]. The stack trace indicates
>> that the call comes from the tg3 module. While this is still kernel 6.2
>> and I can't verify that the issue is still there with newer kernels, I
>> don't see related changes in drivers/net/ethernet/broadcom/tg3.* after
>> ce098da1497c, so I thought I should let you know.
>>
> 
> Thanks for the regression report. I'm adding it to regzbot:
> 
> #regzbot ^introduced: ce098da1497c6d
> #regzbot link: https://forum.proxmox.com/threads/132338/
> 
> PS: The proxmox forum link (except full dmesg log pasted there) is in
> German, so someone fluent in the language can be helpful here.
> 

At the moment, there is not much other text: The user says that they got
the trace after a recent upgrade, but cannot notice any real problems
and I'm telling them that it's a deprecation warning and that I reported
it upstream. If I should ask for some specific information, please let
me know :) But not sure if more information from the user is even
required here or if the fix will just be similar to the one in
8c495270845d ("bnx2x: use the right build_skb() helper").

Best Regards,
Fiona