linux-kernel - RE: [PATCH v3 2/2] gpio: mlxbf3: Support add_pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CH2PR12MB3895048FF2418B8DAE059169D71BA@CH2PR12MB3895.namprd12.prod.outlook.com>
Date:   Fri, 18 Aug 2023 12:08:24 +0000
From:   Asmaa Mnebhi <asmaa@...dia.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "brgl@...ev.pl" <brgl@...ev.pl>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 2/2] gpio: mlxbf3: Support add_pin_ranges()

> Better now,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> 
> ...
> 
> >  #define MLXBF3_GPIO_MAX_PINS_PER_BLOCK 32
> > +#define MLXBF3_GPIO_MAX_PINS_BLOCK0
> MLXBF3_GPIO_MAX_PINS_PER_BLOCK
> > +#define MLXBF3_GPIO_MAX_PINS_BLOCK1    24
> 
> Since it's a fix for backporting, I'm not insisting to amend it now, but can we
> actually drop the common define and use
> 
> #define MLXBF3_GPIO_MAX_PINS_BLOCK0    32
> #define MLXBF3_GPIO_MAX_PINS_BLOCK1    24
> 
> and modify code accordingly, please?
Sure. Will send a v4 addressing this.