linux-kernel - Re: [PATCH 3/6] soc/tegra: fuse: Add function to add lookups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZN961t8WesCG2J0+@smile.fi.intel.com>
Date:   Fri, 18 Aug 2023 17:06:14 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Kartik <kkartik@...dia.com>
Cc:     thierry.reding@...il.com, jonathanh@...dia.com, sumitg@...dia.com,
        arnd@...db.de, pshete@...dia.co, digetx@...il.com,
        petlozup@...dia.com, windhl@....com, frank.li@...o.com,
        robh@...nel.org, stefank@...dia.com, pdeschrijver@...dia.com,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] soc/tegra: fuse: Add function to add lookups

On Fri, Aug 18, 2023 at 03:00:25PM +0530, Kartik wrote:
> Add helper function tegra_fuse_add_lookups() to register Tegra fuse
> nvmem lookups. So, this can be shared between tegra_fuse_init() and
> ACPI probe, which is to be introduced later.

...

> +	size = sizeof(*fuse->lookups) * fuse->soc->num_lookups;

At least this should use size_mul().

> +	fuse->lookups = kmemdup(fuse->soc->lookups, size, GFP_KERNEL);
> +	if (!fuse->lookups)
> +		return -ENOMEM;

But ideally you need to add a patch that brings kmemdup_array().

Okay, it seems it's in the original code :-(
Can you add in your ToDo list to amend this?

-- 
With Best Regards,
Andy Shevchenko