[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CH2PR12MB389516E862515EA0A2A8C4E9D71BA@CH2PR12MB3895.namprd12.prod.outlook.com>
Date: Fri, 18 Aug 2023 14:28:08 +0000
From: Asmaa Mnebhi <asmaa@...dia.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
CC: "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
"bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
"brgl@...ev.pl" <brgl@...ev.pl>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v4 2/2] gpio: mlxbf3: Support add_pin_ranges()
> > Support add_pin_ranges() so that pinctrl_gpio_request() can be called.
> > The GPIO value is not modified when the user runs the "gpioset" tool.
> > This is because when gpiochip_generic_request is invoked by the
> > gpio-mlxbf3 driver, "pin_ranges" is empty so it skips "pinctrl_gpio_request()".
> > pinctrl_gpio_request() is essential in the code flow because it
> > changes the mux value so that software has control over modifying the GPIO
> value.
> > Adding add_pin_ranges() creates a dependency on the pinctrl-mlxbf3.c driver.
> >
> > Fixes: cd33f216d24 ("gpio: mlxbf3: Add gpio driver support")
> > Signed-off-by: Asmaa Mnebhi <asmaa@...dia.com>
>
> You ignored my tag, why?
Oh, you already gave me a "Reviewed-By". Sorry I missed that. And Thank you! I will send a v5 with the tag.
Thanks.
Asmaa
Powered by blists - more mailing lists