linux-kernel - Re: [PATCH bpf-next v5] selftests/bpf: trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_6F0CBE858CB29E2E63544C5FF7461710E909@qq.com>
Date:   Fri, 18 Aug 2023 23:36:13 +0800
From:   Rong Tao <rtoax@...mail.com>
To:     olsajiri@...il.com
Cc:     andrii@...nel.org, ast@...nel.org, bpf@...r.kernel.org,
        daniel@...earbox.net, haoluo@...gle.com, john.fastabend@...il.com,
        kpsingh@...nel.org, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org, martin.lau@...ux.dev,
        mykolal@...com, rongtao@...tc.cn, rtoax@...mail.com,
        sdf@...gle.com, shuah@...nel.org, song@...nel.org,
        yonghong.song@...ux.dev
Subject: Re: [PATCH bpf-next v5] selftests/bpf: trace_helpers.c: optimize kallsyms cache

Hi, jirka

Sadly, we can't include libbpf_internal.h in trace_helpers.{h,c}.
we only have the following headers when compile samples/bpf/:

tree of samples/bpf/libbpf/
    +-- bpf_helper_defs.h
    +-- include
    |   '-- bpf
    |       +-- bpf_core_read.h
    |       +-- bpf_endian.h
    |       +-- bpf.h
    |       +-- bpf_helper_defs.h
    |       +-- bpf_helpers.h
    |       +-- bpf_tracing.h
    |       +-- btf.h
    |       +-- libbpf_common.h
    |       +-- libbpf.h
    |       +-- libbpf_legacy.h
    |       +-- libbpf_version.h
    |       +-- skel_internal.h
    |       '-- usdt.bpf.h
    +-- libbpf.a

No libbpf_internal.h here.

What if we add a declaration to libbpf_ensure_mem() in trace_helpers.c?

Good Day,
Rong Tao