[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CADnq5_OOHM4CcWUps4gput7Jh4m1r=8Z+VK79PG2vF6a3Vgkdg@mail.gmail.com>
Date: Fri, 18 Aug 2023 12:24:25 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: alexander.deucher@....com, linux-hwmon@...r.kernel.org,
jdelvare@...e.com, Xinhui.Pan@....com,
Abaci Robot <abaci@...ux.alibaba.com>,
linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
dri-devel@...ts.freedesktop.org, christian.koenig@....com,
linux@...ck-us.net
Subject: Re: [PATCH] drm/amd/pm: Fix unsigned expression compared with zero
On Thu, Aug 17, 2023 at 2:07 AM Jiapeng Chong
<jiapeng.chong@...ux.alibaba.com> wrote:
>
> The val is defined as unsigned int type, if(val<0) is invalid, modify
> to int type.
>
> drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_pm.c:2813 amdgpu_hwmon_show_power_input() warn: unsigned 'val' is never less than zero.
> drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_pm.c:2800 amdgpu_hwmon_show_power_avg() warn: unsigned 'val' is never less than zero.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6181
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Thanks. The function signatures for amdgpu_hwmon_get_power() and
amdgpu_hwmon_get_sensor_generic() should be fixed up as well. I'll
send out a fix.
Alex
> ---
> drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index 5b1d73b00ef7..fe490e5860d2 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -2794,7 +2794,7 @@ static ssize_t amdgpu_hwmon_show_power_avg(struct device *dev,
> struct device_attribute *attr,
> char *buf)
> {
> - unsigned int val;
> + int val;
>
> val = amdgpu_hwmon_get_power(dev, AMDGPU_PP_SENSOR_GPU_AVG_POWER);
> if (val < 0)
> @@ -2807,7 +2807,7 @@ static ssize_t amdgpu_hwmon_show_power_input(struct device *dev,
> struct device_attribute *attr,
> char *buf)
> {
> - unsigned int val;
> + int val;
>
> val = amdgpu_hwmon_get_power(dev, AMDGPU_PP_SENSOR_GPU_INPUT_POWER);
> if (val < 0)
> --
> 2.20.1.7.g153144c
>
Powered by blists - more mailing lists