linux-kernel - Re: [PATCH] treewide: drop CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c96756ed-8714-6e67-c6b1-0614f57d41d0@csgroup.eu>
Date:   Sat, 19 Aug 2023 08:53:25 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Jesse T <mr.bossman075@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Russell King <linux@...linux.org.uk>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Arnd Bergmann <arnd@...db.de>,
        "Jason A . Donenfeld" <Jason@...c4.com>,
        "wireguard@...ts.zx2c4.com" <wireguard@...ts.zx2c4.com>,
        "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
        "linux-snps-arc@...ts.infradead.org" 
        <linux-snps-arc@...ts.infradead.org>,
        Vineet Gupta <vgupta@...nel.org>,
        Brian Cain <bcain@...cinc.com>,
        "linux-hexagon@...r.kernel.org" <linux-hexagon@...r.kernel.org>,
        Greg Ungerer <gerg@...ux-m68k.org>,
        "linux-m68k@...ts.linux-m68k.org" <linux-m68k@...ts.linux-m68k.org>,
        Michal Simek <monstr@...str.eu>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Dinh Nguyen <dinguyen@...nel.org>,
        Jonas Bonn <jonas@...thpole.se>,
        Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
        Stafford Horne <shorne@...il.com>,
        "linux-openrisc@...r.kernel.org" <linux-openrisc@...r.kernel.org>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>,
        John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
        "linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>,
        Max Filippov <jcmvbkbc@...il.com>,
        Josh Triplett <josh@...htriplett.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        "linux-kbuild@...r.kernel.org" <linux-kbuild@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] treewide: drop CONFIG_EMBEDDED

Hi,

Le 19/08/2023 à 05:33, Jesse T a écrit :
>>>
>>>> Should there be a warning here to update change it instead of removal?
>>>
>>> kconfig doesn't have a warning mechanism AFAIK.
>>> Do you have an idea of how this would work?
> 
> No, unfortunately. As you said without a warning it would be overlooked so
> a change would not be necessary.
> 
> A possible solution is to check in a header file with:
> 
> #ifdef CONFIG_EMBEDDED
> #warning "CONFIG_EMBEDDED has changed to CONFIG_EXPERT"
> #endif
> 
> Does anyone else have an opinion on this?

My opinion is that has happen several times in the past and will happen 
again. It is not a big deal, whoever updates to a new kernel will make a 
savedefconfig and compare with previous defconfig and see what has 
changed. Once you see that CONFIG_EMBEDDED is disappearing you look at 
kernel history to find out why CONFIG_EMBEDDED disappears, and you 
understand from the commit message that you have to select CONFIG_EXPERT 
instead.

A couple examples I have in mind from the past:
- CONFIG_FORCE_MAX_ZONEORDER became CONFIG_ARCH_FORCE_MAX_ORDER
- CONFIG_MTD_NAND became CONFIG_MTD_RAW_NAND

> Since kconfig doesn't have a warning mechanism the patch seems fine as is.

So yes the patch is fine as is IMHO.

Christophe