linux-kernel - Re: [PATCH for-next 0/3] RDMA/hns: Add more debugging information for rdma-tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 19 Aug 2023 14:32:12 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Junxian Huang <huangjunxian6@...ilicon.com>
Cc:     jgg@...dia.com, linux-rdma@...r.kernel.org, linuxarm@...wei.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH for-next 0/3] RDMA/hns: Add more debugging information
 for rdma-tool

On Wed, Aug 16, 2023 at 05:18:09PM +0800, Junxian Huang wrote:
> 1. #1: The first patch supports dumping QP/CQ/MR context entirely in raw
>        data with rdma-tool.
> 
> 2. #2: The second patch supports query of HW stats with rdma-tool.
> 
> 3. #3: The last patch supports query of SW stats with rdma-tool.
> 
> Chengchang Tang (3):
>   RDMA/hns: Dump whole QP/CQ/MR resource in raw
>   RDMA/hns: Support hns HW stats

These two patches generate static analyzer warnings.
➜  kernel git:(wip/leon-for-next) mkt ci --rev 0a68261bbbe5
0a68261bbbe5 (HEAD -> build) RDMA/hns: Dump whole QP/CQ/MR resource in raw
WARNING: 'informations' may be misspelled - perhaps 'information'?
#7:
rdma-tool, but these informations are not enough. It is very
                     ^^^^^^^^^^^^
➜  kernel git:(wip/leon-for-next) mkt ci
5a87279591a1 (HEAD -> build) RDMA/hns: Support hns HW stats
drivers/infiniband/hw/hns/hns_roce_hw_v2.c:1651:35: warning: restricted __le16 degrades to integer

>   RDMA/hns: Support hns SW stats

This is not support SW stats, but actually implementation of SW
statistics which you exposed through rdmatool. That tool is
not right place for such information and debugfs will be better
fit.

Thanks

> 
>  drivers/infiniband/hw/hns/hns_roce_ah.c       |   6 +-
>  drivers/infiniband/hw/hns/hns_roce_cmd.c      |  19 ++-
>  drivers/infiniband/hw/hns/hns_roce_cq.c       |  15 +-
>  drivers/infiniband/hw/hns/hns_roce_device.h   |  50 ++++++
>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c    |  59 +++++++
>  drivers/infiniband/hw/hns/hns_roce_hw_v2.h    |   1 +
>  drivers/infiniband/hw/hns/hns_roce_main.c     | 152 +++++++++++++++++-
>  drivers/infiniband/hw/hns/hns_roce_mr.c       |  26 ++-
>  drivers/infiniband/hw/hns/hns_roce_pd.c       |  10 +-
>  drivers/infiniband/hw/hns/hns_roce_qp.c       |   8 +-
>  drivers/infiniband/hw/hns/hns_roce_restrack.c |  75 +--------
>  drivers/infiniband/hw/hns/hns_roce_srq.c      |   6 +-
>  12 files changed, 325 insertions(+), 102 deletions(-)
> 
> --
> 2.30.0
>