linux-kernel - Re: [PATCH v2 12/13] media: qcom: camss: Add support for setting CSIPHY clock name csiphyX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <179d22c0-c20f-7190-0dce-f439669dc232@linaro.org>
Date:   Sat, 19 Aug 2023 15:21:57 +0100
From:   Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>, rfoss@...nel.org,
        todor.too@...il.com, agross@...nel.org, andersson@...nel.org,
        mchehab@...nel.org, hverkuil-cisco@...all.nl,
        laurent.pinchart@...asonboard.com, sakari.ailus@...ux.intel.com,
        andrey.konovalov@...aro.org
Cc:     linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 12/13] media: qcom: camss: Add support for setting
 CSIPHY clock name csiphyX

On 18/08/2023 13:32, Konrad Dybcio wrote:
> On 17.08.2023 16:38, Bryan O'Donoghue wrote:
>> Several of our upstream and soon-to-be upstream SoC CAMSS dtsi declare
>> csiphyX as opposed to the older clock name csiX_phy.
>>
>> For newer SoCs csiphyX turns out to be a clock you really need to set.
>>
>> On sc8280xp for example we will encounter difficult to track down and
>> root-cause RX CRC errors without setting the csiX_phy clock. On sdm845 and
>> sm8250 we declare the csiXphy clock but seem to get away with not setting
>> it.
>>
>> The right approach here is to set the clock when it is declared. If a SoC
>> doesn't require or a SoC driver implementer doesn't think we need, then the
>> clock ought to simply be omitted from the clock list.
>>
>> Include csiphyX in the set of permissible strings which will subsequently
>> lead to the csiphyX clock being set during csiphy_set_clock_rates() phase.
>>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
>> ---
> So.. is this just a namechange? Is it really necessary?
> 
> Konrad

Not at all no.

We currently don't set csiphyX clocks. That's "not a problem" on sdm845 
and sm8250 "because" but on sc8280xp if you don't set that clock you'll 
get all sorts of RX CRC errors.

Obvs my extensive and detailed commit log transmits exactly no detail.

Let me fix that in the next version.

;)

---
bod