linux-kernel - Re: [PATCH] ubifs: fix missing error code err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0acd50e2-8b0e-0529-9b58-4c92678ab2f9@huawei.com>
Date:   Sat, 19 Aug 2023 10:24:02 +0800
From:   Zhihao Cheng <chengzhihao1@...wei.com>
To:     Ferry Meng <mengferry@...ux.alibaba.com>,
        Richard Weinberger <richard@....at>,
        <linux-mtd@...ts.infradead.org>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ubifs: fix missing error code err

在 2023/8/18 17:18, Ferry Meng 写道:
> Fix smatch warning:
> 
> fs/ubifs/journal.c:1610 ubifs_jnl_truncate() warn: missing error code
> 'err'
> 
> Signed-off-by: Ferry Meng <mengferry@...ux.alibaba.com>
> 

Reviewed-by: Zhihao Cheng <chengzhihao1@...wei.com>

> diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
> index dc52ac0f4a34..ab837b73d4b9 100644
> --- a/fs/ubifs/journal.c
> +++ b/fs/ubifs/journal.c
> @@ -1607,6 +1607,7 @@ int ubifs_jnl_truncate(struct ubifs_info *c, const struct inode *inode,
>   				ubifs_err(c, "bad data node (block %u, inode %lu)",
>   					  blk, inode->i_ino);
>   				ubifs_dump_node(c, dn, dn_size);
> +				err = -EUCLEAN;
>   				goto out_free;
>   			}
>   
>