linux-kernel - Re: [PATCH v4 3/4] clk: qcom: common: add _qcom_cc_really

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4n3vqstyhknanmzx4swwjg4ueaqq2tbrxadnyrx3bchffyf7qr@yh4bik4rfsgm>
Date:   Fri, 18 Aug 2023 19:54:22 -0700
From:   Bjorn Andersson <andersson@...nel.org>
To:     Jie Luo <quic_luoj@...cinc.com>
Cc:     agross@...nel.org, konrad.dybcio@...aro.org,
        mturquette@...libre.com, sboyd@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        catalin.marinas@....com, will@...nel.org, p.zabel@...gutronix.de,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        quic_srichara@...cinc.com
Subject: Re: [PATCH v4 3/4] clk: qcom: common: add _qcom_cc_really_probe

On Fri, Aug 18, 2023 at 04:35:52PM +0800, Jie Luo wrote:
> On 8/18/2023 11:14 AM, Bjorn Andersson wrote:
> > On Tue, Aug 15, 2023 at 04:52:04PM +0800, Luo Jie wrote:
[..]
> > > +int qcom_cc_really_probe(struct platform_device *pdev,
> > > +			 const struct qcom_cc_desc *desc, struct regmap *regmap)
> > 
> > Why do we want to keep this wrapper around?
> > 
> There are many existed clock controller drivers using this wrapper
> qcom_cc_really_probe, so i still keep this wrapper.
> 
> do we need to remove this wrapper and update the existed drivers to use
> _qcom_cc_really_probe?

Yes please. The additional API does not add value, but can be confusing,
so let's invest the extra time in fixing up all the drivers to keep the
interface clean.

Regards,
Bjorn