linux-kernel - [PATCH 3/7] nvmem: sprd: Modify sprd_efuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230819055141.29455-3-yanxin.huang@unisoc.com>
Date:   Sat, 19 Aug 2023 13:51:37 +0800
From:   Yanxin Huang <yanxin.huang@...soc.com>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
CC:     Orson Zhai <orsonzhai@...il.com>,
        Baolin Wang <baolin.wang@...ux.alibaba.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        <linux-kernel@...r.kernel.org>,
        huang yanxin <yanxin.huang07@...il.com>,
        Wenming Wu <wenming.wu@...soc.com>
Subject: [PATCH 3/7] nvmem: sprd: Modify sprd_efuse_write function

The second parameter input to the sprd_efuse_raw_prog() interface
represents the efuse block index. The offset parameter in
sprd_efuse_write represents the offset address after the
efuse->data->blk_offset address, which does not represent the block index,
so passing offset to sprd_efuse_raw_prog() is incorrect.

The formula for calculating the block index is offset /
SPRD_EFUSE_BLOCK_WIDTH + efuse->data->blk_offset, where
SPRD_EFUSE_BLOCK_WIDTH is the size of a block.

This modification adds the parameter index, which calculates the correct
block index based on the offset, and passes it into the
sprd_efuse_raw_prog() interface.

Signed-off-by: Yanxin Huang <yanxin.huang@...soc.com>
---
 drivers/nvmem/sprd-efuse.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/nvmem/sprd-efuse.c b/drivers/nvmem/sprd-efuse.c
index 4f1fcbfec394..3818d83de722 100644
--- a/drivers/nvmem/sprd-efuse.c
+++ b/drivers/nvmem/sprd-efuse.c
@@ -325,6 +325,7 @@ static int sprd_efuse_write(void *context, u32 offset, void *val, size_t bytes)
 {
        struct sprd_efuse *efuse = context;
        bool blk_double = efuse->data->blk_double;
+       u32 index = offset / SPRD_EFUSE_BLOCK_WIDTH + efuse->data->blk_offset;
        bool lock;
        int ret;

@@ -349,7 +350,7 @@ static int sprd_efuse_write(void *context, u32 offset, void *val, size_t bytes)
        else
                lock = true;

-       ret = sprd_efuse_raw_prog(efuse, offset, blk_double, lock, val);
+       ret = sprd_efuse_raw_prog(efuse, index, blk_double, lock, val);

        clk_disable_unprepare(efuse->clk);

--
2.17.1

________________________________
 This email (including its attachments) is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. Unauthorized use, dissemination, distribution or copying of this email or the information herein or taking any action in reliance on the contents of this email or the information herein, by anyone other than the intended recipient, or an employee or agent responsible for delivering the message to the intended recipient, is strictly prohibited. If you are not the intended recipient, please do not read, copy, use or disclose any part of this e-mail to others. Please notify the sender immediately and permanently delete this e-mail and any attachments if you received it in error. Internet communications cannot be guaranteed to be timely, secure, error-free or virus-free. The sender does not accept liability for any errors or omissions.
本邮件及其附件具有保密性质，受法律保护不得泄露，仅发送给本邮件所指特定收件人。严禁非经授权使用、宣传、发布或复制本邮件或其内容。若非该特定收件人，请勿阅读、复制、 使用或披露本邮件的任何内容。若误收本邮件，请从系统中永久性删除本邮件及所有附件，并以回复邮件的方式即刻告知发件人。无法保证互联网通信及时、安全、无误或防毒。发件人对任何错漏均不承担责任。