[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <64e22ce99cfa6_35801629446@willemb.c.googlers.com.notmuch>
Date: Sun, 20 Aug 2023 11:10:33 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Mahmoud Maatuq <mahmoudmatook.mm@...il.com>,
linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
kuba@...nel.org, netdev@...r.kernel.org,
willemdebruijn.kernel@...il.com, davem@...emloft.net,
pabeni@...hat.com, edumazet@...gle.com, shuah@...nel.org
Cc: linux-kernel-mentees@...ts.linuxfoundation.org,
Mahmoud Maatuq <mahmoudmatook.mm@...il.com>
Subject: Re: [PATCH 2/2] selftests/net: replace ternary operator with
min()/max()
Mahmoud Maatuq wrote:
> Fix the following coccicheck warning:
> tools/testing/selftests/net/udpgso_bench_tx.c:297:18-19: WARNING opportunity for min()
> tools/testing/selftests/net/udpgso_bench_tx.c:354:27-28: WARNING opportunity for min()
> tools/testing/selftests/net/so_txtime.c:129:24-26: WARNING opportunity for max()
> tools/testing/selftests/net/so_txtime.c:96:30-31: WARNING opportunity for max()
>
> Signed-off-by: Mahmoud Maatuq <mahmoudmatook.mm@...il.com>
> ---
> tools/testing/selftests/net/Makefile | 2 ++
> tools/testing/selftests/net/so_txtime.c | 7 ++++---
> tools/testing/selftests/net/udpgso_bench_tx.c | 6 +++---
> 3 files changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> index 7f3ab2a93ed6..a06cc25489f9 100644
> --- a/tools/testing/selftests/net/Makefile
> +++ b/tools/testing/selftests/net/Makefile
> @@ -3,6 +3,8 @@
>
> CFLAGS = -Wall -Wl,--no-as-needed -O2 -g
> CFLAGS += -I../../../../usr/include/ $(KHDR_INCLUDES)
> +# Additional include paths needed by kselftest.h
> +CFLAGS += -I../
Why this, instead of the existing include with relative path?
Powered by blists - more mailing lists