linux-kernel - Re: [PATCH 1/2] asm-generic: current: Don't include thread-info.h if building asm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <320be16c-32a2-4f34-9a30-e352f8203671@app.fastmail.com>
Date:   Sat, 19 Aug 2023 19:12:29 -0400
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "David Gow" <davidgow@...gle.com>,
        "Richard Weinberger" <richard@....at>,
        "Anton Ivanov" <anton.ivanov@...bridgegreys.com>,
        "Johannes Berg" <johannes@...solutions.net>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "Ingo Molnar" <mingo@...hat.com>, "Borislav Petkov" <bp@...en8.de>,
        "Dave Hansen" <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        "Noah Goldstein" <goldstein.w.n@...il.com>
Cc:     linux-um@...ts.infradead.org, x86@...nel.org,
        Linux-Arch <linux-arch@...r.kernel.org>,
        "Geert Uytterhoeven" <geert@...ux-m68k.org>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] asm-generic: current: Don't include thread-info.h if building
 asm

On Tue, Jul 4, 2023, at 04:30, David Gow wrote:
> asm/current.h is included by some assembly files (either directly, or
> indirectly). This works on some architectures (such as x86), as their
> implementation of current.h is careful to not include any C, but the
> asm-generic version includes linux/thread-info.h unconditionally, which
> leads to errors when either C code or non-asm-compatible preprocessor
> directives are included.
>
> Just wrap the contents behind an #ifndef __ASSEMBLY__ to avoid any C
> code making its way in.
>
> Signed-off-by: David Gow <davidgow@...gle.com>

Acked-by: Arnd Bergmann <arnd@...db.de>