linux-kernel - Re: [PATCH v0 8/9] media: qcom: camss: Fix set CSI2_RX_CFG1_VC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9447f63a-50a2-d699-606b-b32d16aaa56a@linaro.org>
Date:   Mon, 21 Aug 2023 20:21:41 +0100
From:   Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To:     Hans Verkuil <hverkuil-cisco@...all.nl>, rfoss@...nel.org,
        todor.too@...il.com, agross@...nel.org, andersson@...nel.org,
        konrad.dybcio@...aro.org, mchehab@...nel.org,
        sakari.ailus@...ux.intel.com, andrey.konovalov@...aro.org
Cc:     linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v0 8/9] media: qcom: camss: Fix set CSI2_RX_CFG1_VC_MODE
 when VC is greater than 3

On 21/08/2023 19:51, Bryan O'Donoghue wrote:
> On 21/08/2023 10:53, Hans Verkuil wrote:
>> +        u8 dt_id = vc * 4;
> 
> You're right.
> 
> dt_id = vc is wrong but so is dt_id = vc * 4.
> 
> I'll post a fix for the dt_id as a separate patch.
> 
> ---
> bod

No wait.. dt_id = vc is _fine_

I'll add a patch to document what this does since the provenance of the 
changes for this value are undocumented and confusing even to me, with 
access to the documentation for it.

---
bod