linux-kernel - Re: [PATCH 1/3] dt-bindings: clock: add TWL6032 32K clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Aug 2023 15:57:45 -0500
From:   Rob Herring <robh@...nel.org>
To:     Andreas Kemnade <andreas@...nade.info>
Cc:     mturquette@...libre.com, sboyd@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        bcousson@...libre.com, tony@...mide.com, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: clock: add TWL6032 32K clocks

On Sat, Aug 19, 2023 at 03:41:45PM +0200, Andreas Kemnade wrote:
> To be able to be referenced from a future yaml-version of
> mfd/twl-family.txt depending on toplevel compatible have a separate file
> for the 6032

Really, the parent needs to be done first...

> Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> ---
>  .../bindings/clock/ti,twl6032-clk.yaml        | 38 +++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/ti,twl6032-clk.yaml
> 
> diff --git a/Documentation/devicetree/bindings/clock/ti,twl6032-clk.yaml b/Documentation/devicetree/bindings/clock/ti,twl6032-clk.yaml
> new file mode 100644
> index 0000000000000..aebd9f8d761a2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/ti,twl6032-clk.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/ti,twl6032-clk.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Clocks of the TWL6032 PMIC
> +
> +maintainers:
> +  - Andreas Kemnade <andreas@...nade.info>
> +
> +description:
> +  The TWL6032 has some 32Khz clock outputs which can be controlled.

outputs? Seems like only 1 with no clock cells to specify which one.

> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,twl6032-clk32kaudio
> +      - ti,twl6032-clk32kg

Or is it 1 output per compatible? I hope not.

> +
> +  '#clock-cells':
> +    const: 0
> +
> +required:
> +  - compatible
> +  - '#clock-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    twl {
> +        clk32kaudio {
> +            compatible = "ti,twl6032-clk32kaudio";
> +            #clock-cells = <0>;
> +        };

You don't need a child node to be a clock provider. Just add 
#clock-cells to the parent node.

Rob