linux-kernel - Re: [PATCH 2/4] blk-mq-tag: remove bt_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98296794-01e6-7192-ef3f-0ea454527aaf@acm.org>
Date:   Mon, 21 Aug 2023 14:26:28 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     chengming.zhou@...ux.dev, axboe@...nel.dk, ming.lei@...hat.com,
        hch@....de
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        zhouchengming@...edance.com
Subject: Re: [PATCH 2/4] blk-mq-tag: remove bt_for_each()

On 8/21/23 00:35, chengming.zhou@...ux.dev wrote:
> 2. __blk_mq_tagset_busy_iter() has BT_TAG_ITER_STARTED flag set, so only
>     started requests will be iterated, which should be more efficient.

The above motivation sounds wrong to me. The goal here should be not to
change the behavior of blk_mq_queue_tag_busy_iter(). Although
blk_mq_queue_tag_busy_iter() iterates over more requests than only started
requests, apparently blk_mq_queue_tag_busy_iter() is only used to iterate
over started requests (blk_mq_request_started()). Please mention this in
the patch description.

Thanks,

Bart.