linux-kernel - Re: [PATCH] x86/sev: Make early_set_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABayD+d7imAX98rPp3LKdv0nPFhFkS-r2zJkiacBjQe2tZBQUg@mail.gmail.com>
Date:   Mon, 21 Aug 2023 15:53:21 -0700
From:   Steve Rutherford <srutherford@...gle.com>
To:     Tom Lendacky <thomas.lendacky@....com>
Cc:     Borislav Petkov <bp@...en8.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Ingo Molnar <mingo@...hat.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H . Peter Anvin" <hpa@...or.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, David.Kaplan@....com,
        jacobhxu@...gle.com, patelsvishal@...gle.com, bhillier@...gle.com
Subject: Re: [PATCH] x86/sev: Make early_set_memory_decrypted() calls page aligned

On Mon, Aug 21, 2023 at 1:24 PM Tom Lendacky <thomas.lendacky@....com> wrote:
>
> I like the fix for the hypercall being in early_set_memory_enc_dec(). This
> way the behavior doesn't change for existing callers and doesn't require
> adding a WARN.
>
> Thanks,
> Tom

I uploaded a version based on your earlier advice to have
early_set_mem_enc_dec_hypercall() take a size. I was hesitant since I
thought I'd have to change a ton of callsites, but the line count was
a lot shorter than I expected. This seems like the right way to go
since it directly fixes the problematic rounding.

Thanks,
Steve