[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <946ef7a0-a60b-b6ab-69f8-b169343f36f9@linaro.org>
Date: Mon, 21 Aug 2023 08:29:10 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Jisheng Zhang <jszhang@...nel.org>,
"David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Giuseppe Cavallaro <peppe.cavallaro@...com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org,
linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH net-next 2/3] dt-bindings: net: add T-HEAD dwmac support
On 20/08/2023 14:02, Jisheng Zhang wrote:
> Add documentation to describe T-HEAD dwmac.
>
> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> ---
Thank you for your patch. There is something to discuss/improve.
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/thead,dwmac.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: T-HEAD DWMAC glue layer
Describe/name rather the actual device, not some layer.
> +
> +maintainers:
> + - Jisheng Zhang <jszhang@...nel.org>
> +
> +select:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - thead,th1520-dwmac
> + required:
> + - compatible
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - thead,th1520-dwmac
> + - const: snps,dwmac-3.70a
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: GMAC main clock
> + - description: AXI clock
> +
> + clock-names:
> + items:
> + - const: stmmaceth
> + - const: axi
Isn't basically axi clock a pclk? You should rather use the names from
snps,dwmac
> +
> + thead,gmacapb:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + The phandle to the syscon node that control ethernet
> + interface and timing delay.
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - interrupts
> + - interrupt-names
> + - phy-mode
> + - thead,gmacapb
Best regards,
Krzysztof
Powered by blists - more mailing lists