linux-kernel - Re: [PATCH v5 0/2] Fix Nvidia BlueField-3 GPIO access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZu8BL49QD5DudxW42hrLxmOqUDGeHgTRYF5JBjVMha-g@mail.gmail.com>
Date:   Mon, 21 Aug 2023 09:31:16 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Asmaa Mnebhi <asmaa@...dia.com>
Cc:     andy.shevchenko@...il.com, linux-gpio@...r.kernel.org,
        bgolaszewski@...libre.com, brgl@...ev.pl,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 0/2] Fix Nvidia BlueField-3 GPIO access

On Fri, Aug 18, 2023 at 6:43 PM Asmaa Mnebhi <asmaa@...dia.com> wrote:

> Fix Nvidia BlueField-3 GPIO access via libgpiod gpioset tool.
> gpioset tool fails to modify the GPIO value due to the following:
> 1) the pinctrl-mlxbf3 driver defines mlxbf3_gpio_request_enable()
>    to enable software to take control over a gpio. Only then can
>    the gpio-mlxbf3 driver modify the direction and value of the
>    gpio. mlxbf3_gpio_disable_free() gives control back to hardware
>    and is called when the "gpioset" command is invoked.
>    This cancels out the effort to change the GPIO value and
>    direction. So mlxbf3_gpio_disable_free() needs to be removed.
> 2) the gpio-mlxbf3 driver calls gpiochip_generic_request() which
>    calls mlxbf3_gpio_request_enable(). "pin_ranges" needs not to be
>    empty for mlxbf3_gpio_request_enable() to be invoked. So
>    gpio-mlxbf3 needs to populate "pin_ranges".

This patch set looks good to me!
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij