linux-kernel - Re: [PATCH 2/2] gpio: mxc: switch to dynamic allocat GPIO base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12270129.O9o76ZdvQC@steina-w>
Date:   Mon, 21 Aug 2023 09:44:18 +0200
From:   Alexander Stein <alexander.stein@...tq-group.com>
To:     Bough Chen <haibo.chen@....com>,
        Linus Walleij <linus.walleij@...aro.org>
Cc:     "brgl@...ev.pl" <brgl@...ev.pl>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        "christophe.leroy@...roup.eu" <christophe.leroy@...roup.eu>
Subject: Re: [PATCH 2/2] gpio: mxc: switch to dynamic allocat GPIO base

Hi Linus,

Am Montag, 21. August 2023, 09:25:54 CEST schrieb Linus Walleij:
> On Mon, Aug 21, 2023 at 4:47 AM Bough Chen <haibo.chen@....com> wrote:> > Hi 
Linus and Bartosz,
> > 
> > For this patch, still not in the main trunk (Linux 6.5-rc7) and
> > linux-next(next-20230818). Can you help apply or any comment?
> 
> As pointed out by Bartosz you cannot just mechanically switch the base
> to -1.
> 
> You also need to convince us that this doesn't break any systems, and if
> it does, fix them so they don't break before submitting this patch.

I think it's hard to tell if something breaks, this driver is used in a lot of 
boards. AFAIR some people are relying on the assumption of fixed order. Using 
dynamic allocation this not ensured. A possible fix is to use aliases [1].

Best regards,
Alexander

[1] https://lore.kernel.org/lkml/20230215092421.143199-1-alexander.stein@ew.tq-group.com/T/#u
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/