linux-kernel - Re: [PATCH] mfd: core: Un-constify mfd_cell.of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Aug 2023 09:13:40 +0100
From:   Lee Jones <lee@...nel.org>
To:     Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: core: Un-constify mfd_cell.of_reg

On Sat, 19 Aug 2023, Michał Mirosław wrote:

> On Fri, Aug 18, 2023 at 04:58:15PM +0100, Lee Jones wrote:
> > On Wed, 16 Aug 2023, Michał Mirosław wrote:
> > 
> > > of_reg is the only constant member of struct mfd_cell. It seems to be
> > 
> > Sorry, what?
> > 
> > struct mfd_cell {
> >         const char              *name;
> > [...]
> >         const struct mfd_cell_acpi_match        *acpi_match;
> > [...]
> >         const struct software_node *swnode;
> > [...]
> >         const char              *of_compatible;
> > [...]
> >         const u64 of_reg;
> > [...]
> >         const struct resource   *resources;
> > [...]
> >         const char * const      *parent_supplies;
> > [...]
> > };
> [...]
> 
> All those are pointers to const, not const fields themselves. Only
> `of_reg` is const regardless of the whole structure.

Please make that clear in the commit message.

-- 
Lee Jones [李琼斯]