linux-kernel - RE: [Intel-wired-lan] [PATCH net v3 1/2] Revert "ice: Fix ice VF reset during iavf initialization"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BL0PR11MB3521460DFE459C3CB32B4E688F1EA@BL0PR11MB3521.namprd11.prod.outlook.com>
Date:   Mon, 21 Aug 2023 08:29:04 +0000
From:   "Romanowski, Rafal" <rafal.romanowski@...el.com>
To:     poros <poros@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "Laba, SlawomirX" <slawomirx.laba@...el.com>,
        "przemyslawx.patynowski@...el.com" <przemyslawx.patynowski@...el.com>,
        "Maziarz, Kamil" <kamil.maziarz@...el.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Zulinski, NorbertX" <norbertx.zulinski@...el.com>,
        "dawidx.wesierski@...el.com" <dawidx.wesierski@...el.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "horms@...nel.org" <horms@...nel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH net v3 1/2] Revert "ice: Fix ice VF
 reset during iavf initialization"

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Petr Oros
> Sent: piątek, 11 sierpnia 2023 10:07
> To: netdev@...r.kernel.org
> Cc: Laba, SlawomirX <slawomirx.laba@...el.com>;
> przemyslawx.patynowski@...el.com; Maziarz, Kamil
> <kamil.maziarz@...el.com>; Brandeburg, Jesse
> <jesse.brandeburg@...el.com>; Zulinski, NorbertX
> <norbertx.zulinski@...el.com>; dawidx.wesierski@...el.com;
> edumazet@...gle.com; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; horms@...nel.org; intel-wired-
> lan@...ts.osuosl.org; kuba@...nel.org; pabeni@...hat.com;
> davem@...emloft.net; linux-kernel@...r.kernel.org
> Subject: [Intel-wired-lan] [PATCH net v3 1/2] Revert "ice: Fix ice VF reset
> during iavf initialization"
> 
> This reverts commit 7255355a0636b4eff08d5e8139c77d98f151c4fc.
> 
> After this commit we are not able to attach VF to VM:
> virsh attach-interface v0 hostdev --managed 0000:41:01.0 --mac
> 52:52:52:52:52:52
> error: Failed to attach interface
> error: Cannot set interface MAC to 52:52:52:52:52:52 for ifname
> enp65s0f0np0 vf 0: Resource temporarily unavailable
> 
> ice_check_vf_ready_for_cfg() already contain waiting for reset.
> New condition in ice_check_vf_ready_for_reset() causing only problems.
> 
> Fixes: 7255355a0636 ("ice: Fix ice VF reset during iavf initialization")
> Signed-off-by: Petr Oros <poros@...hat.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> ---
> v3: added tags from previous reviews
> ---
>  drivers/net/ethernet/intel/ice/ice_sriov.c    |  8 ++++----
>  drivers/net/ethernet/intel/ice/ice_vf_lib.c   | 19 -------------------
>  drivers/net/ethernet/intel/ice/ice_vf_lib.h   |  1 -
>  drivers/net/ethernet/intel/ice/ice_virtchnl.c |  1 -
>  4 files changed, 4 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_sriov.c
> b/drivers/net/ethernet/intel/ice/ice_sriov.c
> index 1f66914c7a202a..31314e7540f8cf 100644
> --- a/drivers/net/ethernet/intel/ice/ice_sriov.c
> +++ b/drivers/net/ethernet/intel/ice/ice_sriov.c
> @@ -1131,7 +1131,7 @@ int ice_set_vf_spoofchk(struct net_device


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>