linux-kernel - Re: [PATCH 4/6] dt-bindings: power: add Amlogic T7 power domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa2aa42d-9701-6d09-1a0c-9e7d18f83b5c@amlogic.com>
Date:   Mon, 21 Aug 2023 17:40:22 +0800
From:   Xianwei Zhao <xianwei.zhao@...ogic.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Kevin Hilman <khilman@...libre.com>
Subject: Re: [PATCH 4/6] dt-bindings: power: add Amlogic T7 power domains

Hi Krzystof,
      Thanks for your review.

On 2023/8/19 22:20, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> On 17/08/2023 09:11, Xianwei Zhao wrote:
>> From: "xianwei.zhao" <xianwei.zhao@...ogic.com>
> 
>> @@ -21,6 +21,7 @@ properties:
>>         - amlogic,meson-a1-pwrc
>>         - amlogic,meson-s4-pwrc
>>         - amlogic,c3-pwrc
>> +      - amlogic,t7-pwrc
>>
>>     "#power-domain-cells":
>>       const: 1
>> diff --git a/include/dt-bindings/power/amlogic,t7-pwrc.h b/include/dt-bindings/power/amlogic,t7-pwrc.h
>> new file mode 100644
>> index 000000000000..b7a13eda563c
>> --- /dev/null
>> +++ b/include/dt-bindings/power/amlogic,t7-pwrc.h
>> @@ -0,0 +1,63 @@
>> +/* SPDX-License-Identifier: (GPL-2.0-only OR .*) */
> 
> This does not look correct license. Use one recommended by checkpatch.
> 
Will fix it in next version.
> 
> 
> Best regards,
> Krzysztof
>