[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6c76b28e-e995-2082-6dfa-378002989bcd@linaro.org>
Date: Mon, 21 Aug 2023 10:59:18 +0100
From: Tudor Ambarus <tudor.ambarus@...aro.org>
To: Nicolas Ferre <nicolas.ferre@...rochip.com>,
Varshini Rajendran <varshini.rajendran@...rochip.com>,
herbert@...dor.apana.org.au, davem@...emloft.net,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, alexandre.belloni@...tlin.com,
claudiu.beznea@...rochip.com, linux-crypto@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 11/50] dt-bindings: crypto: add sam9x7 in Atmel TDES
On 8/21/23 09:59, Nicolas Ferre wrote:
> On 28/07/2023 at 12:24, Varshini Rajendran wrote:
>> Add DT bindings for atmel TDES.
this commit message is way too succinct and hides the complexity that's
needed in the driver
>>
>> Signed-off-by: Varshini Rajendran <varshini.rajendran@...rochip.com>
>
> Following my answer to the email thread:
> Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>
>
> Thanks, best regards,
> Nicolas
>
>> ---
>> .../devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml
>> b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml
>> index 3d6ed24b1b00..6a441f79efea 100644
>> ---
>> a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml
>> +++
>> b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-tdes.yaml
>> @@ -12,7 +12,11 @@ maintainers:
>> properties:
>> compatible:
>> - const: atmel,at91sam9g46-tdes
>> + oneOf:
>> + - const: atmel,at91sam9g46-tdes
>> + - items:
>> + - const: microchip,sam9x7-tdes
>> + - const: atmel,at91sam9g46-tdes
why do you backup to "atmel,at91sam9g46-tdes"? Simply relying on
"microchip,sam9x7-tdes" and its of_device_id data should be enough.
>> reg:
>> maxItems: 1
>
Powered by blists - more mailing lists