linux-kernel - Re: [PATCH] pinctrl: amd: Mask wake bits on probe again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdaM820GMVyViKKkvFHfgAnNt2f3DvoZbC9HT1d7FBPBXg@mail.gmail.com>
Date:   Mon, 21 Aug 2023 12:29:28 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Mario Limonciello <mario.limonciello@....com>
Cc:     Basavaraj.Natikar@....com, Shyam-sundar.S-k@....com,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Sachi King <nakato@...ato.io>, stable@...r.kernel.org,
        Thorsten Leemhuis <regressions@...mhuis.info>,
        Shubhra Prakash Nandi <email2shubhra@...il.com>,
        Carsten Hatger <xmb8dsv4@...il.com>
Subject: Re: [PATCH] pinctrl: amd: Mask wake bits on probe again

On Fri, Aug 18, 2023 at 4:49 PM Mario Limonciello
<mario.limonciello@....com> wrote:

> Shubhra reports that their laptop is heating up over s2idle. Even though
> it's getting into the deepest state, it appears to be having spurious
> wakeup events.
>
> While debugging a tangential issue with the RTC Carsten reports that recent
> 6.1.y based kernel face a similar problem.
>
> Looking at acpidump and GPIO register comparisons these spurious wakeup
> events are from the GPIO associated with the I2C touchpad on both laptops
> and occur even when the touchpad is not marked as a wake source by the
> kernel.
>
> This means that the boot firmware has programmed these bits and because
> Linux didn't touch them lead to spurious wakeup events from that GPIO.
>
> To fix this issue, restore most of the code that previously would clear all
> the bits associated with wakeup sources. This will allow the kernel to only
> program the wake up sources that are necessary.
>
> This is similar to what was done previously; but only the wake bits are
> cleared by default instead of interrupts and wake bits.  If any other
> problems are reported then it may make sense to clear interrupts again too.
>
> Cc: Sachi King <nakato@...ato.io>
> Cc: stable@...r.kernel.org
> Cc: Thorsten Leemhuis <regressions@...mhuis.info>
> Fixes: 65f6c7c91cb2 ("pinctrl: amd: Revert "pinctrl: amd: disable and mask interrupts on probe"")
> Reported-by: "Shubhra Prakash Nandi" <email2shubhra@...il.com>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217754
> Reported-by: "Carsten Hatger" <xmb8dsv4@...il.com>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217626#c28
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>

Patch applied for fixes so we get some rotation in linux-next.

Thanks for looking into this Mario!

Yours,
Linus Walleij