linux-kernel - Re: [PATCH 0/4] drm/amdgpu: Explicitly add a flexible array at the end of 'struct amdgpu_bo_list' and simplify amdgpu_bo_list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d52550a-92a1-55e7-69ad-92f18330ff48@amd.com>
Date:   Mon, 21 Aug 2023 13:03:46 +0200
From:   Christian König <christian.koenig@....com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Arunpravin.PaneerSelvam@....com,
        "Prosyak, Vitaly" <Vitaly.Prosyak@....com>,
        "Sharma, Shashank" <Shashank.Sharma@....com>
Cc:     kernel-janitors@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        amd-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Felix.Kuehling@....com, daniel@...ll.ch, airlied@...il.com,
        Xinhui.Pan@....com, christian.koenig@....com,
        alexander.deucher@....com
Subject: Re: [PATCH 0/4] drm/amdgpu: Explicitly add a flexible array at the
 end of 'struct amdgpu_bo_list' and simplify amdgpu_bo_list_create()

Am 20.08.23 um 11:51 schrieb Christophe JAILLET:
> This serie simplifies amdgpu_bo_list_create() and usage of the 'struct
> amdgpu_bo_list'.

Oh, yes please. That's something I always wanted to cleanup as well.

> It is compile tested only.

That bothers me a bit. Arun, Vitaly, Shashank can anybody with time run 
a quick test on this? Preferable the IGT tests, but this just some game 
should probably do as well.

Apart from that looks good to me,
Christian.

>
> Christophe JAILLET (4):
>    drm/amdgpu: Explicitly add a flexible array at the end of 'struct
>      amdgpu_bo_list'
>    drm/amdgpu: Remove a redundant sanity check
>    drm/amdgpu: Remove amdgpu_bo_list_array_entry()
>    drm/amdgpu: Use kvzalloc() to simplify code
>
>   drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 15 ++-------------
>   drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.h | 18 ++++++------------
>   2 files changed, 8 insertions(+), 25 deletions(-)
>