linux-kernel - Re: [PATCH] platform/x86: ideapad-laptop: Add support for new hotkeys found on ThinkBook 14s Yoga ITL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d537df6-d5b1-835c-b856-1783747f4eb4@redhat.com>
Date:   Mon, 21 Aug 2023 13:13:03 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     André Apitzsch <git@...tzsch.eu>,
        Ike Panhc <ike.pan@...onical.com>,
        Mark Gross <markgross@...nel.org>
Cc:     platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: ideapad-laptop: Add support for new hotkeys
 found on ThinkBook 14s Yoga ITL

Hi,

On 8/19/23 09:12, André Apitzsch wrote:
> The Lenovo Thinkbook 14s Yoga ITL has 4 new symbols/shortcuts on their
> F9-F11 and PrtSc keys:
> 
> F9:    Has a symbol of a head with a headset, the manual says "Service key"
> F10:   Has a symbol of a telephone horn which has been picked up from the
>        receiver, the manual says: "Answer incoming calls"
> F11:   Has a symbol of a telephone horn which is resting on the receiver,
>        the manual says: "Reject incoming calls"
> PrtSc: Has a symbol of a siccor and a dashed ellipse, the manual says:
>        "Open the Windows 'Snipping' Tool app"
> 
> This commit adds support for these 4 new hkey events.
> 
> Signed-off-by: André Apitzsch <git@...tzsch.eu>

Thank you for your patch, I've applied this patch to my fixes
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes

Note it will show up in my fixes branch once I've pushed my
local branch there, which might take a while.

I will include this patch in my next fixes pull-req to Linus
for the current kernel development cycle.

Regards,

Hans

> ---
>  drivers/platform/x86/ideapad-laptop.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index d2fee9a3e239..6d9297c1d96c 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -1049,6 +1049,11 @@ static const struct key_entry ideapad_keymap[] = {
>  	{ KE_IGNORE,	0x03 | IDEAPAD_WMI_KEY },
>  	/* Customizable Lenovo Hotkey ("star" with 'S' inside) */
>  	{ KE_KEY,	0x01 | IDEAPAD_WMI_KEY, { KEY_FAVORITES } },
> +	{ KE_KEY,	0x04 | IDEAPAD_WMI_KEY, { KEY_SELECTIVE_SCREENSHOT } },
> +	/* Lenovo Support */
> +	{ KE_KEY,	0x07 | IDEAPAD_WMI_KEY, { KEY_HELP } },
> +	{ KE_KEY,	0x0e | IDEAPAD_WMI_KEY, { KEY_PICKUP_PHONE } },
> +	{ KE_KEY,	0x0f | IDEAPAD_WMI_KEY, { KEY_HANGUP_PHONE } },
>  	/* Dark mode toggle */
>  	{ KE_KEY,	0x13 | IDEAPAD_WMI_KEY, { KEY_PROG1 } },
>  	/* Sound profile switch */
> 
> ---
> base-commit: 7271b2a530428b879443b274c191b34536a4ea11
> change-id: 20230819-lenovo_keys-ed658f4d34d7
> 
> Best regards,