linux-kernel - Re: [PATCH 2/6] soc/tegra: fuse: Add function to register nvmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Aug 2023 17:04:09 +0530
From:   Kartik <kkartik@...dia.com>
To:     <andriy.shevchenko@...ux.intel.com>
CC:     <arnd@...db.de>, <digetx@...il.com>, <frank.li@...o.com>,
        <jonathanh@...dia.com>, <kkartik@...dia.com>,
        <linux-kernel@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        <pdeschrijver@...dia.com>, <petlozup@...dia.com>,
        <pshete@...dia.com>, <robh@...nel.org>, <stefank@...dia.com>,
        <sumitg@...dia.com>, <thierry.reding@...il.com>, <windhl@....com>
Subject: Re: [PATCH 2/6] soc/tegra: fuse: Add function to register nvmem

On Fri, 2023-08-18 at 16:50 +0300, Andy Shevchenko wrote:

>On Fri, Aug 18, 2023 at 03:00:24PM +0530, Kartik wrote:
>> Add helper function tegra_fuse_nvmem_register() to register
>> Tegra Fuse nvmem and use it in tegra_fuse_probe(). So, this can be
>> shared between device-tree and ACPI probe, which is to be introduced
>> later.
>
>...
>
>> +	fuse->nvmem = devm_nvmem_register(dev, &nvmem);
>> +	if (IS_ERR(fuse->nvmem)) {
>
>> +		err = PTR_ERR(fuse->nvmem);
>> +		dev_err(dev, "failed to register NVMEM device: %d\n",
>> +			err);
>> +		return err;
>
>		return dev_err_probe();
>
>> +	}
>> +
>> +	return 0;
>> +}
>
>...
>
>Seems it comes from the original code, so consider this as a suggestion for
>an additional improvement.
>
>-- 
>With Best Regards,
>Andy Shevchenko

Thanks Andy, I will update this.


Regards,
Kartik