[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMuHMdXo07jXLL6pn=J+Y-wPGT_wccST4wCbE01bRH3r2xf_qQ@mail.gmail.com>
Date: Mon, 21 Aug 2023 14:09:40 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Rob Herring <robh@...nel.org>
Cc: Frank Rowand <frowand.list@...il.com>,
"Enrico Weigelt, metux IT consult" <info@...ux.net>,
"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Petr Mladek <pmladek@...e.com>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Geert Uytterhoeven <geert+renesas@...der.be>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/6] of: dynamic: Refactor changeset action printing to
common helpers
Hi Rob,
Thanks for the update!
On Fri, Aug 18, 2023 at 10:41 PM Rob Herring <robh@...nel.org> wrote:
> Several places print the changeset action with node and property
> details. Refactor these into a common printing helper. The complicating
> factor is some prints are debug and some are errors. Solve this with a
> bit of preprocessor magic.
>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
> v3:
> - Drop printing changeset entry pointers
I think it would be good to mention this in the actual patch
description, too.
> --- a/drivers/of/dynamic.c
> +++ b/drivers/of/dynamic.c
> @@ -598,7 +568,7 @@ static int __of_changeset_entry_apply(struct of_changeset_entry *ce)
> unsigned long flags;
> int ret = 0;
>
> - __of_changeset_entry_dump(ce);
> + of_changeset_action_debug("applying: ", ce->action, ce->np, ce->prop);
s/applying/apply/ ?
The rest LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Powered by blists - more mailing lists