linux-kernel - Re: [RFC][PATCH] kconfig: introduce listunknownconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Aug 2023 21:27:12 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Sergey Senozhatsky <senozhatsky@...omium.org>
Cc:     Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nicolas Schier <nicolas@...sle.eu>,
        Jonathan Corbet <corbet@....net>,
        Tomasz Figa <tfiga@...omium.org>, linux-kbuild@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH] kconfig: introduce listunknownconfig

On Sun, Aug 20, 2023 at 5:15 PM Sergey Senozhatsky
<senozhatsky@...omium.org> wrote:
>
> On (23/08/20 16:21), Sergey Senozhatsky wrote:
> > What the preferred approach would be? Do we want a new KCONFIG_FOO env
> > variable that changes behaviour of one of the targets? E.g.
> >
> >       KCONFIG_LIST_MISSING=1 make oldconfig
> >
> > and then have conf list symbols and terminate with exit(1) if there are
> > some unrecognized symbols?
>
>
> Will something like this be OK with you?
>
>
>  KCONFIG_LIST_MISSING=1 make oldconfig
>
> .config:6:warning: unknown symbol: DISABLE_BUGS
> .config:7:warning: unknown unset symbol: ENABLE_WINAPI
>
> make[2]: *** [scripts/kconfig/Makefile:77: oldconfig] Error 1
>


Yup, much better than adding a new target.



> ---
>
> diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
> index fa2ae6f63352..b2c0bcf0e5c1 100644
> --- a/scripts/kconfig/confdata.c
> +++ b/scripts/kconfig/confdata.c
> @@ -360,7 +360,9 @@ int conf_read_simple(const char *name, int def)
>         char *p, *p2;
>         struct symbol *sym;
>         int i, def_flags;
> +       const char *list_missing;
>
> +       list_missing = getenv("KCONFIG_LIST_MISSING");


My (original) hope was to add a single switch, KCONFIG_VERBOSE, to address both:

  - A CONFIG option is hidden by unmet dependency (Ying Sun's case)
  - A CONFIG option no longer exists  (your case)
  - Anything else we need to be careful



>         if (name) {
>                 in = zconf_fopen(name);
>         } else {
> @@ -448,6 +450,12 @@ int conf_read_simple(const char *name, int def)
>                         if (def == S_DEF_USER) {
>                                 sym = sym_find(line + 2 + strlen(CONFIG_));
>                                 if (!sym) {
> +                                       if (list_missing) {
> +                                               conf_warning("unknown unset symbol: %s",
> +                                                            line + 2 + strlen(CONFIG_));
> +                                               continue;
> +                                       }
> +
>                                         conf_set_changed(true);
>                                         continue;
>                                 }
> @@ -482,6 +490,12 @@ int conf_read_simple(const char *name, int def)
>
>                         sym = sym_find(line + strlen(CONFIG_));
>                         if (!sym) {
> +                               if (list_missing) {
> +                                       conf_warning("unknown symbol: %s",
> +                                                    line + strlen(CONFIG_));
> +                                       continue;
> +                               }
> +


This should be warned only if (def != S_DEF_AUTO),
otherwise the same warning will be displayed twice.



>                                 if (def == S_DEF_AUTO)
>                                         /*
>                                          * Reading from include/config/auto.conf
> @@ -530,6 +544,13 @@ int conf_read_simple(const char *name, int def)
>         }
>         free(line);
>         fclose(in);
> +
> +       if (list_missing) {
> +               if (conf_warnings)
> +                       exit(1);
> +               exit(0);
> +       }
> +

This is something different because you are making these
errors instead of warnings.



>         return 0;
>  }



-- 
Best Regards
Masahiro Yamada