linux-kernel - Re: [PATCH 5.17 127/298] driver core: Fix wait_for_device_probe() & deferred_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a06a54e-0348-4964-ab90-48c648712ed6@sirena.org.uk>
Date:   Mon, 21 Aug 2023 14:11:30 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Robin Murphy <robin.murphy@....com>
Cc:     Shreeya Patel <shreeya.patel@...labora.com>,
        Saravana Kannan <saravanak@...gle.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org, John Stultz <jstultz@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Sudeep Holla <sudeep.holla@....com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        Basil Eljuse <Basil.Eljuse@....com>,
        Ferry Toth <fntoth@...il.com>, Arnd Bergmann <arnd@...db.de>,
        Anders Roxell <anders.roxell@...aro.org>,
        linux-pm@...r.kernel.org, Nathan Chancellor <nathan@...nel.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
        "gustavo.padovan@...labora.com" <gustavo.padovan@...labora.com>,
        Ricardo Cañuelo Navarro 
        <ricardo.canuelo@...labora.com>,
        Guillaume Charles Tucker <guillaume.tucker@...labora.com>,
        usama.anjum@...labora.com, kernelci@...ts.linux.dev
Subject: Re: [PATCH 5.17 127/298] driver core: Fix wait_for_device_probe() &
 deferred_probe_timeout interaction

On Mon, Aug 21, 2023 at 01:39:11PM +0100, Robin Murphy wrote:
> On 2023-08-21 12:35, Shreeya Patel wrote:

> > AFAIK, script for running the tests is immediately ran after the boot
> > process is complete so there is no wait time.

> Regardless of what the kernel is doing, it seems like a fundamentally dumb
> test to specifically ask deferred probe to wait for up to a minute then
> complain that it hasn't finished after 11 seconds :/

IIRC that stuff is expecting the modules to be loaded from the initramfs
and checking from the main system which is a bit more sensible (at least
in the case where there is a main filesystem).  It's vulnerable to races
but less so, especially given the time a Debian rootfs typically takes
to boot over NFS.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)