linux-kernel - Re: [PATCH drm-misc-next] drm/nouveau: uvmm: fix unset region pointer on remap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPM=9txjnd_MrhANjoGqJ4iU1sNvz92MdsRUm_XbzGR-=daBTg@mail.gmail.com>
Date:   Mon, 21 Aug 2023 12:53:09 +1000
From:   Dave Airlie <airlied@...il.com>
To:     Danilo Krummrich <dakr@...hat.com>
Cc:     daniel@...ll.ch, bskeggs@...hat.com, kherbst@...hat.com,
        lyude@...hat.com, dri-devel@...ts.freedesktop.org,
        nouveau@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH drm-misc-next] drm/nouveau: uvmm: fix unset region pointer
 on remap

Reviewed-by: Dave Airlie <airlied@...hat.com>

On Mon, 21 Aug 2023 at 08:29, Danilo Krummrich <dakr@...hat.com> wrote:
>
> Transfer the region pointer of a uvma to the new uvma(s) on re-map to
> prevent potential shader faults when the re-mapped uvma(s) are unmapped.
>
> Signed-off-by: Danilo Krummrich <dakr@...hat.com>
> ---
>  drivers/gpu/drm/nouveau/nouveau_uvmm.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_uvmm.c b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
> index 3a1e8538f205..aae780e4a4aa 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_uvmm.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_uvmm.c
> @@ -639,6 +639,7 @@ nouveau_uvmm_sm_prepare(struct nouveau_uvmm *uvmm,
>                         struct drm_gpuva *va = r->unmap->va;
>                         struct uvmm_map_args remap_args = {
>                                 .kind = uvma_from_va(va)->kind,
> +                               .region = uvma_from_va(va)->region,
>                         };
>                         u64 ustart = va->va.addr;
>                         u64 urange = va->va.range;
>
> base-commit: 25205087df1ffe06ccea9302944ed1f77dc68c6f
> --
> 2.41.0
>