linux-kernel - Re: [PATCH 1/2] pinctrl: mediatek: fix pull

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f25a5a59b790c6988ed54003230ccab2b941675.camel@mediatek.com>
Date:   Mon, 21 Aug 2023 14:18:05 +0000
From:   sam.shih@...iatek.com
To:     "daniel@...rotopia.org" <daniel@...rotopia.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>
CC:     "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "frank-w@...lic-files.de" <frank-w@...lic-files.de>,
        "robh@...nel.org" <robh@...nel.org>,
        "sean.wang@...nel.org" <sean.wang@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH 1/2] pinctrl: mediatek: fix pull_type data for MT7981

On Mon, 2023-08-21 at 12:40 +0200, Linus Walleij wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Fri, Aug 18, 2023 at 5:02 AM Daniel Golle <daniel@...rotopia.org>
> wrote:
> 
> > MediaTek has released pull_type data for MT7981 in their SDK.
> > Use it and set functions to configure pin bias.
> >
> > Fixes: 6c83b2d94fcc ("pinctrl: add mt7981 pinctrl driver")
> > Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> 
> This looks pretty urgent but I applied it for v6.6 (non-urgent)
> for now so we get some testing in linux-next.
> 
The MediaTek MT7981 SoC only has pin0 to pin56 which defined in
'mt7981_pins', This patch removes the non-existent pin57 to pin100 and
fixes the pull type for pins 40 through 56.

The driver can still work due to the pin numbers of MT7981 is defined
by ARRAY_SIZE(mt7981_pins), and the default hardware configuration for
pins 40 through 56 can work correctly without advanced adjustments,
However, without this patch, attempts to use pinconf to configure pins
40 through 56 result in a "-EINVAL" error.


Acked-by: Sam Shih <sam.shih@...iatek.com>


Best Regards,
Sam