linux-kernel - Re: [PATCH RFT v2] arm64: dts: qcom: sc7280: drop incorrect EUD port on SoC side

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=V=0RDo0UPBr4PcWE5jgmMg_HXYxXyG1WoLkjYOh4_gCw@mail.gmail.com>
Date:   Mon, 21 Aug 2023 07:19:29 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     cros-qcom-dts-watchers@...omium.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bhupesh Sharma <bhupesh.sharma@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Souradeep Chowdhury <quic_schowdhu@...cinc.com>
Subject: Re: [PATCH RFT v2] arm64: dts: qcom: sc7280: drop incorrect EUD port
 on SoC side

Hi,

On Sun, Aug 20, 2023 at 12:56 AM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> Qualcomm Embedded USB Debugger (EUD) second port should point to Type-C
> USB connector.  Such connector was defined directly in root node of
> sc7280.dtsi which is clearly wrong.  SC7280 is a chip, so physically it
> does not have USB Type-C port.  The connector is usually accessible
> through some USB switch or controller.
>
> Doug Anderson said that he wasn't ever able to use EUD on Herobrine
> boards, probably because of invalid or missing DTS description - DTS is
> saying EUD is on usb_2 node, which is connected to a USB Hub, not to the
> Type-C port.
>
> Correct the EUD/USB connector topology by removing the top-level fake
> USB connector and EUD port pointing to it, and disabling the incomplete
> EUD device node.
>
> This fixes also dtbs_check warnings:
>
>   sc7280-herobrine-crd.dtb: connector: ports:port@0: 'reg' is a required property
>
> Link: https://lore.kernel.org/all/CAD=FV=Xt26=rBf99mzkAuwwtb2f-jnKtnHaEhXnthz0a5zke4Q@mail.gmail.com/
> Fixes: 9ee402ccfeb1 ("arm64: dts: qcom: sc7280: Fix EUD dt node syntax")
> Cc: Souradeep Chowdhury <quic_schowdhu@...cinc.com>
> Cc: Bhupesh Sharma <bhupesh.sharma@...aro.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
> ---
>
> Not tested on hardware.
>
> Changes in v2:
> 1. Disable the EUD node and do not add ports/connector in boards, as
>    discussed with Doug.
>
> v1: https://lore.kernel.org/all/CAD=FV=Xt26=rBf99mzkAuwwtb2f-jnKtnHaEhXnthz0a5zke4Q@mail.gmail.com/
> ---
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 21 ++-------------------
>  1 file changed, 2 insertions(+), 19 deletions(-)

I have no objections, but also no objections if someone who actually
knows how the EUD is setup wants to respond and tell you the right way
for this to get setup. Thus, I guess:

Reviewed-by: Douglas Anderson <dianders@...omium.org>