linux-kernel - Re: [PATCH v3 08/12] PM: EM: Introduce runtime modifiable table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Aug 2023 16:25:47 +0100
From:   Lukasz Luba <lukasz.luba@....com>
To:     Dietmar Eggemann <dietmar.eggemann@....com>
Cc:     rui.zhang@...el.com, amit.kucheria@...durent.com,
        amit.kachhap@...il.com, daniel.lezcano@...aro.org,
        viresh.kumar@...aro.org, len.brown@...el.com, pavel@....cz,
        Pierre.Gondois@....com, ionela.voinescu@....com,
        mhiramat@...nel.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org, rafael@...nel.org
Subject: Re: [PATCH v3 08/12] PM: EM: Introduce runtime modifiable table



On 8/16/23 14:05, Dietmar Eggemann wrote:
> On 21/07/2023 17:50, Lukasz Luba wrote:
>> This patch introduces the new feature: modifiable EM perf_state table.
> 
> nit pick: The first sentence doesn't add any information. I would skip it.
> 
> [...]
> 
>> The runtime modifiable EM data is used by the Energy Aware Scheduler (EAS)
>> for the task placement. The EAS is the only user of the 'runtime
>> modifiable EM'.
> 
> The runtime modifiable EM is currently only used ...
> The you can skip the next sentence: "The EAS is the only user ..."
> 
> All the other users (thermal, etc.) are still using the
>> default (basic) EM. This fact drove the design of this feature.
> 
> [...]
> 

Thanks, I'll remove them in the next version.