linux-kernel - Re: [PATCH v3 10/12] PM: EM: Add runtime update interface to modify EM power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6dbcebb-a743-0aa8-1596-5345e0500aa3@arm.com>
Date:   Mon, 21 Aug 2023 16:33:43 +0100
From:   Lukasz Luba <lukasz.luba@....com>
To:     Dietmar Eggemann <dietmar.eggemann@....com>
Cc:     rui.zhang@...el.com, amit.kucheria@...durent.com,
        amit.kachhap@...il.com, daniel.lezcano@...aro.org,
        viresh.kumar@...aro.org, len.brown@...el.com, pavel@....cz,
        Pierre.Gondois@....com, ionela.voinescu@....com,
        mhiramat@...nel.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org, rafael@...nel.org
Subject: Re: [PATCH v3 10/12] PM: EM: Add runtime update interface to modify
 EM power



On 8/16/23 14:07, Dietmar Eggemann wrote:
> On 21/07/2023 17:50, Lukasz Luba wrote:
> 
> [...]
> 
>> @@ -381,6 +383,12 @@ static inline int em_pd_nr_perf_states(struct em_perf_domain *pd)
>>   {
>>   	return 0;
>>   }
>> +static inline
>> +int em_dev_update_perf_domain(struct device *dev, struct em_data_callback *cb,
>> +			      void *priv)
>> +{
>> +	return -EINVAL;
>> +}
>>   #endif
>>   
>>   #endif
>> diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c
>> index 4596bfe7398e..10180c776c5b 100644
>> --- a/kernel/power/energy_model.c
>> +++ b/kernel/power/energy_model.c
>> @@ -185,6 +185,101 @@ static int em_compute_costs(struct device *dev, struct em_perf_state *table,
>>   	return 0;
>>   }
>>   
>> +/**
>> + * em_dev_update_perf_domain() - Update run-time EM table for a device
> 
> nit pick: s/run-time/runtime
> 
> there are multiple occurrences in this file (maybe more in the entire set?)
> 
> [...]

Yes, there are 5 occurrences in the whole patch set. I'll change them.