linux-kernel - Re: [PATCH 1/2] arm64: dts: ti: k3-am62-main: PM fixes in the fss node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0137b4f7-799f-14ce-3cd6-0af24cab2d8a@ti.com>
Date:   Mon, 21 Aug 2023 11:28:12 -0500
From:   Andrew Davis <afd@...com>
To:     Dhruva Gole <d-gole@...com>, Mark Brown <broonie@...nel.org>,
        Nishanth Menon <nm@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-spi@...r.kernel.org>, Vibhore Vardhan <vibhore@...com>
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-am62-main: PM fixes in the fss
 node

On 8/18/23 5:37 AM, Dhruva Gole wrote:
> * Make use of Simple Power-Managed Bus as the fss bus controller is under
> the control of a functional clock, and also is part of a PM domain.
> * Specify the appropriate k3 pd to the fss node as per tisci docs [0].
> 
> [0] https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/am62x/devices.html
> 

This doc makes it look like the number should be 73, but you have 74, what is FSAS?

Andrew

> Fixes: c37c58fdeb8a ("arm64: dts: ti: k3-am62: Add more peripheral nodes")
> Co-developed-by: Vibhore Vardhan <vibhore@...com>
> Signed-off-by: Vibhore Vardhan <vibhore@...com>
> Signed-off-by: Dhruva Gole <d-gole@...com>
> ---
>   arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index 284b90c94da8..b23c9e3d91cd 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -640,10 +640,11 @@ usb1: usb@...00000 {
>   	};
>   
>   	fss: bus@...0000 {
> -		compatible = "simple-bus";
> +		compatible = "simple-pm-bus";
>   		reg = <0x00 0x0fc00000 0x00 0x70000>;
>   		#address-cells = <2>;
>   		#size-cells = <2>;
> +		power-domains = <&k3_pds 74 TI_SCI_PD_EXCLUSIVE>;
>   		ranges;
>   
>   		ospi0: spi@...0000 {