linux-kernel - Re: [PATCH] vdpa_sim_blk: Fix the potential leak of mgmt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACGkMEs=B6yswCE0O_J+_X_XO9bPx-R+dM9SvSM77wyoCTroDg@mail.gmail.com>
Date:   Mon, 21 Aug 2023 11:59:23 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     "Shawn.Shao" <shawn.shao@...uarmicro.com>
Cc:     mst@...hat.com, xuanzhuo@...ux.alibaba.com,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, lege.wang@...uarmicro.com
Subject: Re: [PATCH] vdpa_sim_blk: Fix the potential leak of mgmt_dev

On Mon, Aug 21, 2023 at 10:18 AM Shawn.Shao <shawn.shao@...uarmicro.com> wrote:
>
> If the shared_buffer allocation fails, need to unregister mgmt_dev first.
>

Please add a Fixes tag.

Other than this

Acked-by: Jason Wang <jasowang@...hat.com>

Thanks

> Signed-off-by: Shawn.Shao <shawn.shao@...uarmicro.com>
> ---
>  drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
> index 00d7d72713be..b3a3cb165795 100644
> --- a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
> +++ b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c
> @@ -499,12 +499,13 @@ static int __init vdpasim_blk_init(void)
>                                          GFP_KERNEL);
>                 if (!shared_buffer) {
>                         ret = -ENOMEM;
> -                       goto parent_err;
> +                       goto mgmt_dev_err;
>                 }
>         }
>
>         return 0;
> -
> +mgmt_dev_err:
> +       vdpa_mgmtdev_unregister(&mgmt_dev);
>  parent_err:
>         device_unregister(&vdpasim_blk_mgmtdev);
>         return ret;
> --
> 2.34.1
>