linux-kernel - [irqchip: irq/irqchip-next] irqchip/imx-mu-msi: Do not check for 0 return after calling platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <169263708570.27769.11175640997927949490.tip-bot2@tip-bot2>
Date:   Mon, 21 Aug 2023 16:58:05 -0000
From:   "irqchip-bot for Ruan Jinjie" <tip-bot2@...utronix.de>
To:     linux-kernel@...r.kernel.org
Cc:     Ruan Jinjie <ruanjinjie@...wei.com>, Marc Zyngier <maz@...nel.org>,
        tglx@...utronix.de
Subject: [irqchip: irq/irqchip-next] irqchip/imx-mu-msi: Do not check for 0
 return after calling platform_get_irq()

The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID:     2f54db449b6185024ef884fd3083802e1eae6921
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/2f54db449b6185024ef884fd3083802e1eae6921
Author:        Ruan Jinjie <ruanjinjie@...wei.com>
AuthorDate:    Thu, 03 Aug 2023 16:34:51 +08:00
Committer:     Marc Zyngier <maz@...nel.org>
CommitterDate: Mon, 21 Aug 2023 17:42:00 +01:00

irqchip/imx-mu-msi: Do not check for 0 return after calling platform_get_irq()

It is not possible for platform_get_irq() to return 0. Use the
return value from platform_get_irq().

Signed-off-by: Ruan Jinjie <ruanjinjie@...wei.com>
Signed-off-by: Marc Zyngier <maz@...nel.org>
Link: https://lore.kernel.org/r/20230803083452.4085650-2-ruanjinjie@huawei.com
---
 drivers/irqchip/irq-imx-mu-msi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-imx-mu-msi.c b/drivers/irqchip/irq-imx-mu-msi.c
index 229039e..90d41c1 100644
--- a/drivers/irqchip/irq-imx-mu-msi.c
+++ b/drivers/irqchip/irq-imx-mu-msi.c
@@ -339,8 +339,8 @@ static int __init imx_mu_of_init(struct device_node *dn,
 	msi_data->msiir_addr = res->start + msi_data->cfg->xTR;
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq <= 0)
-		return -ENODEV;
+	if (irq < 0)
+		return irq;
 
 	platform_set_drvdata(pdev, msi_data);