linux-kernel - Re: [PATCH] selftests: Keep symlinks, when possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZOTZHhGLnQKOhITt@d3>
Date:   Tue, 22 Aug 2023 11:49:50 -0400
From:   Benjamin Poirier <bpoirier@...dia.com>
To:     Björn Töpel <bjorn@...nel.org>
Cc:     Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Björn Töpel <bjorn@...osinc.com>,
        Jonathan Toppins <jtoppins@...hat.com>
Subject: Re: [PATCH] selftests: Keep symlinks, when possible

On 2023-08-22 15:58 +0200, Björn Töpel wrote:
> From: Björn Töpel <bjorn@...osinc.com>
> 
> When kselftest is built/installed with the 'gen_tar' target, rsync is
> used for the installation step to copy files. Extra care is needed for
> tests that have symlinks. Commit ae108c48b5d2 ("selftests: net: Fix
> cross-tree inclusion of scripts") added '-L' (transform symlink into
> referent file/dir) to rsync, to fix dangling links. However, that
> broke some tests where the symlink (being a symlink) is part of the
> test (e.g. exec:execveat).
> 
> Use rsync's '--copy-unsafe-links' that does right thing.
> 
> Fixes: ae108c48b5d2 ("selftests: net: Fix cross-tree inclusion of scripts")
> Signed-off-by: Björn Töpel <bjorn@...osinc.com>
> ---
>  tools/testing/selftests/lib.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Benjamin Poirier <bpoirier@...dia.com>

Thank you for the fix.