[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CADDJ8CXD05H22G=NsUcZy-uG5+4xQRpCd-UPVL1Z1a0Lybx9+Q@mail.gmail.com>
Date: Tue, 22 Aug 2023 10:21:37 -0700
From: Denis Nikitin <denik@...omium.org>
To: linux-kbuild@...r.kernel.org
Cc: Masahiro Yamada <masahiroy@...nel.org>,
Nathan Chancellor <nathan@...nel.org>,
Nicolas Schier <nicolas@...sle.eu>, Tom Rix <trix@...hat.com>,
linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
Nick Desaulniers <ndesaulniers@...gle.com>,
Fangrui Song <maskray@...gle.com>
Subject: Re: [PATCH] modpost: Skip .llvm.call-graph-profile section check
On Tue, Aug 22, 2023 at 8:47 AM Nick Desaulniers
<ndesaulniers@...gle.com> wrote:
>
> On Mon, Aug 21, 2023 at 11:54 PM Denis Nikitin <denik@...omium.org> wrote:
> >
> > .llvm.call-graph-profile section is added when the kernel is built with
> > profiles (e.g. -fprofile-sample-use=<llvm.profile>). The section holds
> > metadata for symbols beloning to other sections and hence doesn't need
> > modpost checks.
> >
> > This change fixes the kernel build with sample profiles which fails
> > with:
> > "FATAL: modpost: Please add code to calculate addend for this architecture"
> >
> > Signed-off-by: Denis Nikitin <denik@...omium.org>
>
> Thanks for the patch. If you send a v2 with Fangrui's suggested
> changes+additions, feel free to carry forward my reviewed by tag.
>
> Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>
>
Thanks! Will do shortly.
- Denis
Powered by blists - more mailing lists