linux-kernel - Re: [PATCH v1 8/9] media: qcom: camss: Fix set CSI2_RX_CFG1_VC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Aug 2023 21:03:57 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Bryan O'Donoghue <bryan.odonoghue@...aro.org>, rfoss@...nel.org,
        todor.too@...il.com, agross@...nel.org, andersson@...nel.org,
        mchehab@...nel.org, hverkuil-cisco@...all.nl,
        laurent.pinchart@...asonboard.com, sakari.ailus@...ux.intel.com,
        andrey.konovalov@...aro.org
Cc:     linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v1 8/9] media: qcom: camss: Fix set CSI2_RX_CFG1_VC_MODE
 when VC is greater than 3

On 22.08.2023 21:03, Bryan O'Donoghue wrote:
> On 22/08/2023 17:32, Konrad Dybcio wrote:
>>>       val = 1 << CSI2_RX_CFG1_PACKET_ECC_CORRECTION_EN;
>>> +    if (vc > 3)
>> I hope you don't pull your hair out, but I think GENMASK(1,0) could be
> 
> 
> I generally dislike the pattern of 1 << value in this code but, it's not something I'm proposing to solve at this time.
> 
>> in order here with a comment about the bitlength requirements
> 
> Not parsing the bitlength requirements comment, whatdoyoumean ?
The thing you mentioned in the commit message, it could also be a
hint in the code above the if-statement.

Konrad