linux-kernel - Re: [PATCH] apparmor: remove unused PROF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6d9e4dd9-4197-bbd1-eaf5-d79db0605ea3@canonical.com>
Date:   Tue, 22 Aug 2023 12:28:18 -0700
From:   John Johansen <john.johansen@...onical.com>
To:     "GONG, Ruiqi" <gongruiqi@...weicloud.com>,
        Paul Moore <paul@...l-moore.com>,
        James Morris <jmorris@...ei.org>,
        "Serge E . Hallyn" <serge@...lyn.com>
Cc:     apparmor@...ts.ubuntu.com, linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Xiu Jianfeng <xiujianfeng@...wei.com>,
        Wang Weiyang <wangweiyang2@...wei.com>
Subject: Re: [PATCH] apparmor: remove unused PROF_* macros

On 8/7/23 02:39, GONG, Ruiqi wrote:
> From: "GONG, Ruiqi" <gongruiqi1@...wei.com>
> 
> The last usage of PROF_{ADD,REPLACE} were removed by commit 18e99f191a8e
> ("apparmor: provide finer control over policy management"). So remove
> these two unused macros.
> 
> Signed-off-by: GONG, Ruiqi <gongruiqi1@...wei.com>

sorry, I seem to have dropped my reply to this, I have
pulled this into apparmor-next

Acked-by: John Johansen <john.johansen@...onical.com>

> ---
>   security/apparmor/include/policy.h | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/security/apparmor/include/policy.h b/security/apparmor/include/policy.h
> index 545f791cabda..ed9a8669af80 100644
> --- a/security/apparmor/include/policy.h
> +++ b/security/apparmor/include/policy.h
> @@ -254,9 +254,6 @@ ssize_t aa_remove_profiles(struct aa_ns *view, struct aa_label *label,
>   			   char *name, size_t size);
>   void __aa_profile_list_release(struct list_head *head);
>   
> -#define PROF_ADD 1
> -#define PROF_REPLACE 0
> -
>   #define profile_unconfined(X) ((X)->mode == APPARMOR_UNCONFINED)
>   
>   /**