linux-kernel - Re: [PATCH V2] thermal: intel: intel_soc_dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gLnqxTPux9x=aGhLQoNAwkANPy4UoT0gYEchayE20=DQ@mail.gmail.com>
Date:   Tue, 22 Aug 2023 22:08:35 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Zhang Rui <rui.zhang@...el.com>
Cc:     rafael.j.wysocki@...el.com, daniel.lezcano@...aro.or,
        srinivas.pandruvada@...el.com, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH V2] thermal: intel: intel_soc_dts_iosf: Remove redundant check

On Sun, Aug 13, 2023 at 4:52 AM Zhang Rui <rui.zhang@...el.com> wrote:
>
> Remove the redundant check in remove_dts_thermal_zone() because all of
> its existing callers pass a valid pointer as the argument.
>
> Signed-off-by: Zhang Rui <rui.zhang@...el.com>
> ---
>  drivers/thermal/intel/intel_soc_dts_iosf.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/thermal/intel/intel_soc_dts_iosf.c b/drivers/thermal/intel/intel_soc_dts_iosf.c
> index db97499f4f0a..22fc2970c67d 100644
> --- a/drivers/thermal/intel/intel_soc_dts_iosf.c
> +++ b/drivers/thermal/intel/intel_soc_dts_iosf.c
> @@ -245,11 +245,9 @@ static int soc_dts_enable(int id)
>
>  static void remove_dts_thermal_zone(struct intel_soc_dts_sensor_entry *dts)
>  {
> -       if (dts) {
> -               iosf_mbi_write(BT_MBI_UNIT_PMC, MBI_REG_WRITE,
> -                              SOC_DTS_OFFSET_ENABLE, dts->store_status);
> -               thermal_zone_device_unregister(dts->tzone);
> -       }
> +       iosf_mbi_write(BT_MBI_UNIT_PMC, MBI_REG_WRITE,
> +                      SOC_DTS_OFFSET_ENABLE, dts->store_status);
> +       thermal_zone_device_unregister(dts->tzone);
>  }
>
>  static int add_dts_thermal_zone(int id, struct intel_soc_dts_sensor_entry *dts,
> --

Applied as 6.6 material, thanks!