linux-kernel - Re: [PATCH] clk: fix slab-out-of-bounds error in devm_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <37ddd03b5c6f7a32f1733d9b6122d06b.sboyd@kernel.org>
Date:   Tue, 22 Aug 2023 15:24:25 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Alexandru Ardelean <aardelean@...iqon.com>,
        Andrey Skvortsov <andrej.skvortzov@...il.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Michael Turquette <mturquette@...libre.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Andrey Skvortsov <andrej.skvortzov@...il.com>
Subject: Re: [PATCH] clk: fix slab-out-of-bounds error in devm_clk_release

Quoting Andrey Skvortsov (2023-08-05 01:48:47)
> Problem can be reproduces by unloading snd_soc_simple_card, because in
> devm_get_clk_from_child data were allocated as `struct clk`,
> but devm_clk_release expects `struct devm_clk_state`.
> 
[...]
> Fixes: abae8e57e49a ("clk: generalize devm_clk_get() a bit")
> Signed-off-by: Andrey Skvortsov <andrej.skvortzov@...il.com>
> ---

Applied to clk-fixes but I removed the state->exit assignment because
that's the default. I also noticed that devm_clk_put() is broken in a
similar way. Sheesh!